Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mdl-layout screen resize memory leak #5431

Open
wants to merge 41 commits into
base: mdl-1.x
Choose a base branch
from
Open

Fix mdl-layout screen resize memory leak #5431

wants to merge 41 commits into from

Commits on Jul 2, 2024

  1. Fix memory leaks. 

     - Remove event handlers from `window` when the tooltip is not showing.
- Get rid of component deconstruction remnants.

`downgradeElements` was updated in dec 2015 to not actually do any downgrading, because at the time none of the components needed deconstruction. A memory leak was then added to the Tooltip component in May 2016.

These changes to `downgradeElements` were problematic:
 - It still removes the `data-upgraded` attributes from dom elements, even though no deconstruction actually happened. This means that calling `upgradElement` again will double-upgrade the element.
 - the `createComponents_` array no longer serves any purpose.
    @ribrdb
    ribrdb committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e8141de View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge pull request #1 from derivita/ribrdb/memleaks 

    Fix memory leaks.
    @ribrdb
    ribrdb authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5c94dd6 View commit details
    Browse the repository at this point in the history

  2. Update radio.js 

    Fix Radio focus bug.
    @ribrdb
    ribrdb authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    eb09760 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix for possibly undefined placeholder

    @ehalsmer
    ehalsmer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    07dd0fd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from derivita/ehalsmer/fix-undefined-textfield-… 

    …placeholder

Fix undefined textfield placeholder
    @ehalsmer
    ehalsmer authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    650a98e View commit details
    Browse the repository at this point in the history

  3. Replace ? with explicit undefined check

    @ehalsmer
    ehalsmer committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c56ec3c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from derivita/ehalsmer/modify-textfield-fix 

    Modify textfield fix to remove ?
    @ehalsmer
    ehalsmer authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d96333c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Remove resize and pageshow listeners in MaterialLayout (#4)

    @ehalsmer
    ehalsmer authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    132b66e View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Remove extra newline (#5)

    @ehalsmer
    ehalsmer authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ddfe15d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Add reviewdog workflow

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    931218e View commit details
    Browse the repository at this point in the history

  2. Use npm for the cache

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2c9facb View commit details
    Browse the repository at this point in the history

  3. Add package lock file

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dcba4c0 View commit details
    Browse the repository at this point in the history

  4. Rename to ci.yml and add tests

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d863be4 View commit details
    Browse the repository at this point in the history

  5. Create a specific CI npm run

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    946af60 View commit details
    Browse the repository at this point in the history

  6. add all the unit tests

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    69bfe86 View commit details
    Browse the repository at this point in the history

  7. Actually run the script

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    80c8571 View commit details
    Browse the repository at this point in the history

  8. update closure compiler path

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    20be522 View commit details
    Browse the repository at this point in the history

  9. remove review dog for now

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    95f81b5 View commit details
    Browse the repository at this point in the history

  10. Update the git clean tree check

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    379cfb9 View commit details
    Browse the repository at this point in the history

  11. Revert to using the test script

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a29f050 View commit details
    Browse the repository at this point in the history

  12. Remove reviewdog name

    @rivernate
    rivernate committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    556aec7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge pull request #7 from derivita/nathan/reviewdog 

    Add CI Build for tests
    @ribrdb
    ribrdb authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6295cb6 View commit details
    Browse the repository at this point in the history

  2. Fix mem leak

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    49ff685 View commit details
    Browse the repository at this point in the history

  3. Make screenResizeHanlder local and use change event

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    bf8251b View commit details
    Browse the repository at this point in the history

  4. Make the media query global

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e0c4664 View commit details
    Browse the repository at this point in the history

  5. Loop over all layouts

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    25123a6 View commit details
    Browse the repository at this point in the history

  6. Update src/layout/layout.js 

    Co-authored-by: Ryan Brown <ryan@derivita.com>
    @jakelauritsen @ribrdb
    jakelauritsen and ribrdb committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2ac6dfe View commit details
    Browse the repository at this point in the history

  7. Only add one listener for all layouts

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    873dc20 View commit details
    Browse the repository at this point in the history

  8. Formatting adjustments

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fde3ac6 View commit details
    Browse the repository at this point in the history

  9. Clean Linter

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2ed0df3 View commit details
    Browse the repository at this point in the history

  10. Add nvmrc

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    89b260b View commit details
    Browse the repository at this point in the history

  11. Clean linter

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    971e663 View commit details
    Browse the repository at this point in the history

  12. Fix es5 error

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    243ed70 View commit details
    Browse the repository at this point in the history

  13. Fixing tests that rely on window.mediaQuery

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    499e3ad View commit details
    Browse the repository at this point in the history

  14. Clean linter

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    e864a23 View commit details
    Browse the repository at this point in the history

  15. No need for .nvmrc

    @jakelauritsen
    jakelauritsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8ce3abd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Register a mock media list if one exists on the static def of layout

    @jakelauritsen
    jakelauritsen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c63e700 View commit details
    Browse the repository at this point in the history

  2. Make screenSizeMediaQuery static and add update docs

    @jakelauritsen
    jakelauritsen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cbb40d5 View commit details
    Browse the repository at this point in the history

  3. Use static method for storing the matchMedia

    @jakelauritsen
    jakelauritsen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    11d7b23 View commit details
    Browse the repository at this point in the history

  4. Make matchMedia static and update doc for closure

    @jakelauritsen
    jakelauritsen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1c203b9 View commit details
    Browse the repository at this point in the history

  5. Fix test typo

    @jakelauritsen
    jakelauritsen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    83e468c View commit details
    Browse the repository at this point in the history