Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append and fix entries in symbols.tsv #1074

Merged
merged 22 commits into from
Oct 30, 2024

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 9, 2024

Description

  • Add convenient ways to type symbols and fix missing ways (e.g. "ちょさくけん" → "©" (non-emoji), "+ー" → "±")
  • Force non-emoji styles for Red Dragon because it can be emoji
  • Fix description of Horizontal Bar
  • Make possible to convert kana with dakuten (e.g. あ゙) without direct codepoint conversion
  • Add cbrt & qdrt symbols

Issue IDs

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: any
  1. "どうじょう", "おなじく" , "のの", "ののじ", "ののてん", "ののじてん"→ 〃
  2. Horiontal Bar U+2015 (from "-") is described as "水平")
  3. "+" → "-" → Space generates ±, and "-" → "+" → Space generates ∓
  4. Double hypen is suggested by "=" → Space
  5. "d" "o" "c" Space suggests ℃
  6. "d" "o" "f" Space etc. suggests Fahrenheit degree signs
  7. "さいころ" + number or number → Space suggest the corresponding dice symbol
  8. In GitHub, "ほんちゅん" → Space suggests the non-emoji text symbol
  9. "ちょさくけん" suggests non-emoji copyright symbol
  10. あ → " → Space produces あ゙.
  11. (In kana mode) あ → ゛ → Space produces あ゙

It's a pain in the buttocks to enumerate all cases in this week. I'll update this in next week.

Additional context

Add any other context about the pull request here.

VS-15 (U+FE0E) is added after Red Dragon and Black Joker.

One or both of Fahrenheit signs can be removed.

@tats-u tats-u changed the title Revise symbols Append and fix entries in symbols.tsv Oct 9, 2024
Copy link
Collaborator

@hiroyuki-komatsu hiroyuki-komatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi tsts-u,
Thank you for your PR!

Please check my comments.

src/data/symbol/symbol.tsv Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
Copy link
Collaborator

@hiroyuki-komatsu hiroyuki-komatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PRs in future, please refrain from adding the contents in the middle of the review.
Thank you,

src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
@tats-u
Copy link
Contributor Author

tats-u commented Oct 16, 2024

I thought it is a little pain of a neck to switch or merge multiple sets of symbols addition.
I'll make sure to create another branch on additional symbols.
e.g Yijing Hexagram Symbols (六十四卦), which are sometimes treated to be a part of CJK or not, and Kanbun symbols.

Copy link
Collaborator

@hiroyuki-komatsu hiroyuki-komatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. We are almost there.

src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
src/data/symbol/symbol.tsv Outdated Show resolved Hide resolved
@hiroyuki-komatsu
Copy link
Collaborator

When the PR is updated, I have to run the internal process again from the beginning. So I would like to keep PRs while reviewing. If PRs should be updated, please let us know that.

@tats-u
Copy link
Contributor Author

tats-u commented Oct 30, 2024

Sorry about that. Now I don't have to append any additional fonts m commits anymore.

@hiroyuki-komatsu hiroyuki-komatsu merged commit 4857e53 into google:master Oct 30, 2024
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

We have merged this PR.
Thank you for the contribution!

@tats-u tats-u deleted the add-symbols2 branch October 30, 2024 21:34
hiroyuki-komatsu added a commit that referenced this pull request Jan 16, 2025
2.30.5618 → 2.31.5712

Conversion
* Updated the LM dictionary
* Updated symbols (#1074, #1100)
* Updated emoji data to CLDR 46 (Emoji 16.0)
* Fixed conversion errors reported by users.

Bug fix
* Windows: fixed the freeze issue with some applications like the searchhost.exe (#1077, #856)
* Windows: fixed the UI language issue of the GUI tools (#1110)

Features
* Updated the copyright year to 2025.
* Windows: bundle debug symbol for Mozc TIP DLL (#1081)
* Windows: shutdown existing Mozc processes on upgrading the version (#1093)

Build
* supported Bazel 8.0.0 (#1118)
* removed WORKSPACE support for Bazel (#1115)
* supported Python 3.14 (#1084)
* updated the protobuf version: v27.3 → v29.1.
* Linux: supported gcc-14.1.1 without additional build flags (#927)
* macOS / Windows: Updated Qt version: 6.7.3 → 6.8.0 (#1105, #1110, #1121)

Code
* added a lint checker for BUILD.bazel and *bzl files (#1089)
* renamed the protobuf field from Candidates to CandidateWindow
* refactoring of ConversionRequest making it as immutable object
* refactoring of the Converter implementation
* refactoring of Engine and SessionConverter to make each module pluggable
* removed cyclic dependency between Converter and Rewriter.

PiperOrigin-RevId: 716215275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants