Fix #1077: Deprecate Mozc_tsf_ui.log

[yukawa]

Description

This is a quick fix for #1077.

While #1077 itself is not the root cause of #1076, merging this commit would also help debugging #1076 with debug builds.

Issue IDs

#1077

Steps to test new behaviors

A clear and concise description about how to verify new behaviors.

• OS: Windows 11 23H2
• Steps:
  1. Create and install a debug version of Mozc64.msi
  2. Build and launch the following app.
  3. Select Mozc

#include <windows.h>

int WINAPI wWinMain(HINSTANCE instance_handle, HINSTANCE prev_instance_handle,
                    PWSTR command_line, int command_show) {
  const wchar_t window_class_name[] = L"Test Window Class";
  {
    const WNDCLASS wc = {
        .lpfnWndProc = [](HWND window_handle, UINT message,
                          auto... params) -> LRESULT {
          if (message == WM_DESTROY) {
            ::PostQuitMessage(0);
            return 0;
          }
          return ::DefWindowProc(window_handle, message, params...);
        },
        .hInstance = instance_handle,
        .hbrBackground = (HBRUSH)(COLOR_WINDOW + 1),
        .lpszClassName = window_class_name,
    };
    ::RegisterClass(&wc);
  }

  const HWND window_handle = ::CreateWindowEx(
      0, window_class_name, L"Window Title", WS_OVERLAPPEDWINDOW, CW_USEDEFAULT,
      CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, nullptr, nullptr,
      instance_handle, nullptr);

  if (window_handle == nullptr) {
    return 0;
  }

  ::ShowWindow(window_handle, command_show);

  while (true) {
    MSG message = {};
    if (::GetMessage(&message, nullptr, 0, 0) <= 0) {
      break;
    }
    ::TranslateMessage(&message);
    ::DispatchMessage(&message);
  }

  return 0;
}

Without this commit, the app crashes because of the same reason as #856.

[hiroyuki-komatsu]

Hi yukawa,
Thank you for your PR!

[hiroyuki-komatsu]

How about commenting out them with a note why the log is not stored into a file?

[yukawa]

I'm actually wondering if we can permanently deprecate the log file, as it's not reliable (we cannot write file from AppContainer process) and I suspect no one is checking it as it is only available in debug build. At least I in general do not rely on log files for debugging.

Are you still using *.log from other processes? I'm actually leaning towards deprecating other logging files, but it's a separate discussion after fixing this obvious crash bug.

[hiroyuki-komatsu]

I'm fine to permanently deprecate the log file.
I'd like to prevent anyone from creating the log file again in the future, since it may cause the crash issue again.

So adding a note instead of the comment out is also fine with me.