Crash when setFramesPerCallback(#frames) is used for input stream

[katyo]

Android Version(s): 9
Android Device(s): several
Oboe Version: latest

Short Description

I develop an app which operates with constantly sized buffer of frames. So I set the number of frames per callback with builder.setFramesPerCallback(256) but the aaudio backend crashes in this case.

Steps To Reproduce

Set the number of frames per callback using builder.setFramesPerCallback(N_of_frames).

Expected behavior

Normal operating.

Actual behavior

SIGABRT with:

F/AudioStreamRecord(26563): maybeConvertDeviceData() conversion size 512 too large for buffer 256
F/libc    (26563): Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 26636 (AudioRecord), pid 26563
<...>
backtrace:
    #00 pc 0000000000021afc  /system/lib64/libc.so (abort+124)
    #01 pc 00000000000080f8  /system/lib64/liblog.so (__android_log_assert+296)
    #02 pc 0000000000031b94  /system/lib64/libaaudio.so (aaudio::AudioStreamRecord::maybeConvertDeviceData(void const*, int)+236)
    #03 pc 000000000002e30c  /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::callDataCallbackFrames(unsigned char*, int)+260)
    #04 pc 00000000000371a4  /system/lib64/libaaudio.so (FixedBlockWriter::processVariableBlock(unsigned char*, int)+220)
    #05 pc 000000000002e928  /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::processCallbackCommon(int, void*)+696)
    #06 pc 000000000005ab04  /system/lib64/libaudioclient.so (android::AudioRecord::processAudioBuffer()+1396)
    #07 pc 000000000005a27c  /system/lib64/libaudioclient.so (android::AudioRecord::AudioRecordThread::threadLoop()+252)
    #08 pc 000000000000fb78  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+280)
    #09 pc 000000000008429c  /system/lib64/libc.so (__pthread_start(void*)+36)
    #10 pc 00000000000233fc  /system/lib64/libc.so (__start_thread+68)

Additional context

Also I sets channels count to 1 (mono) if it matter.

[philburk]

Thank you! I was able to reproduce this on master using OboeTester on Pixel 3a:

1. launch OboeTester
2. enter "Callback size:" 64
3. tap TEST INPUT
4. uncheck the MMAP box so we use the Legacy path
5. tap OPEN
6. tap START

Internal bug tracker at: 149249791

We should be able to add a workaround by using a BlockSizeAdapter in Oboe.

[rpattabi]

We hit this problem when we tried to start input stream. Any update on this issue? We would appreciate a workaround.

[philburk]

I'll work on this next week.

[rpattabi]

Few high priority issues were identified for this release v1.5. Any idea when this release can be expected? Rough idea about the release will help us plan our work.

[philburk]

09-14 16:48:08.434 9495 9495 F DEBUG : Abort message: 'maybeConvertDeviceData() conversion size 128 too large for buffer 64'
(__android_log_assert+296)
09-14 16:48:08.440 9495 9495 F DEBUG : #2 pc 0000000000031b94 /system/lib64/libaaudio.so (aaudio::AudioStreamRecord::maybeConvertDeviceData(void const*, int)+236)
09-14 16:48:08.440 9495 9495 F DEBUG : #3 pc 000000000002e30c /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::callDataCallbackFrames(unsigned char*, int)+260)
09-14 16:48:08.440 9495 9495 F DEBUG : #4 pc 00000000000371a4 /system/lib64/libaaudio.so (FixedBlockWriter::processVariableBlock(unsigned char*, int)+220)
09-14 16:48:08.440 9495 9495 F DEBUG : #5 pc 000000000002e928 /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::processCallbackCommon(int, void*)+696)
09-14 16:48:08.440 9495 9495 F DEBUG : #6 pc 00000000000599ac /system/lib64/libaudioclient.so (android::AudioRecord::processAudioBuffer()+1396)

[philburk]

This is tracked internally in
b/149249791 | AAudio INPUT asserts if AAudioStreamBuilder_setFramesPerDataCallback(small) used
A fix for this is in R AAudio.

[philburk]

@rpattabi - does PR #1011 fix this problem for you?

[rpattabi]

On Nokia 5.1 Plus (Android 10), we still experience the same crash. This is what we did:

1. Pulled cbsizeproxy branch and built oboe tester.
2. Built and launched oboe tester.
3. Set callback size to 256
4. Test Input > Open > Start

Crashes with

09-15 10:21:23.299  9392  9447 F AudioStreamRecord: maybeConvertDeviceData() conversion size 512 too large for buffer 256
09-15 10:21:23.299  9392  9447 F libc    : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 9447 (AudioRecord), pid 9392 (oboe.manualtest)

It crashes irrespective of the callback size. If we set 512, the error reads conversion size 1024 too large for buffer 512. Native crash stack trace is at https://gist.github.com/rpattabi/7bd4e814b9af7d3aff09298621f17f59

Device details:

ro.product.brand = Nokia
ro.product.manufacturer = HMD Global
ro.product.model = Nokia 5.1 Plus
ro.product.device = PDA_sprout
ro.product.cpu.abi = arm64-v8a
ro.build.description = Panda_00WW-user 10 QP1A.190711.020 00WW_3_11E release-keys
ro.hardware = mt6771

If you want us to check anything specific, please let us know.

[rpattabi]

Got the latest from master which has this change. Tried the scenario I mentioned in the previous message. It crashed as before. However, I realize that I didn't check "enable Oboe workarounds" before.

With workarounds enabled, there is no crash and input works fine on the same device (Nokia 5.1 plus). I guess that's the reason this issue is closed which makes sense. Thank you.