Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setFramesPerCallback can cause a crash on close for output tracks #973

Closed
philburk opened this issue Aug 9, 2020 · 0 comments · Fixed by #1011
Closed

setFramesPerCallback can cause a crash on close for output tracks #973

philburk opened this issue Aug 9, 2020 · 0 comments · Fixed by #1011
Assignees
@philburk
Labels
P1 high priority
Milestone
v1.5

Comments

@philburk
Copy link
Collaborator

philburk commented Aug 9, 2020

For legacy output tracks, the block size adapter can get deleted while a callback is still in progress.
We should intercept calls to setFramesPerCallback() and do the block size adaption in Oboe instead of AAudio.
There should not be any performance penalty.

This is related to #953
This will also help fix #778
@philburk philburk added the P1 high priority label Aug 9, 2020
@philburk philburk self-assigned this Aug 9, 2020
@philburk philburk added this to the v1.5 milestone Sep 9, 2020
philburk added a commit that referenced this issue Sep 15, 2020
@philburk
oboe: use proxy for callback size adapter
554b5f8 
Avoid using callback size adapters in AAudio because of various bugs.
If setFramesPerCallback() called then use a filter stream and do the
block size adaptation in Oboe as part of the data conversion flowgraph.

Fixes #778
Fixes #973
Fixes #983
@philburk philburk mentioned this issue Sep 15, 2020
Merged
philburk added a commit that referenced this issue Sep 16, 2020
@philburk
oboe: use proxy for callback size adapter
6d5a4f9 
Avoid using callback size adapters in AAudio because of various bugs.
If setFramesPerCallback() called then use a filter stream and do the
block size adaptation in Oboe as part of the data conversion flowgraph.

Fixes #778
Fixes #973
Fixes #983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
P1 high priority
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

oboe: use proxy for callback size adapter google/oboe
1 participant
@philburk