Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSL ES: Check zero buffer depth and enqueue before setRecordState for input streams #1621

Merged
merged 1 commit into from
Sep 14, 2022
Merged

OpenSL ES: Check zero buffer depth and enqueue before setRecordState for input streams #1621

merged 1 commit into from
Sep 14, 2022

Conversation

robertwu1
Copy link
Collaborator

This PR does 2 things:

  1. Check buffer depth before enqueuing for input streams. This is the input equivalent of Fix start,pause,start in OpenSL ES #625.
  2. Queue an callback buffer before setting record state to recording. This is the input equivalent of OpenSL ES: Call processBufferCallback before setting the playstate to playing #1570.

Fixes #1431

@robertwu1 robertwu1 mentioned this pull request Sep 7, 2022
Closed
@robertwu1 robertwu1 requested a review from philburk September 7, 2022 23:09
@robertwu1 robertwu1 merged commit 5975ab0 into main Sep 14, 2022
@robertwu1 robertwu1 deleted the robertwu/openslinputenqueue branch September 14, 2022 17:29
@robertwu1 robertwu1 restored the robertwu/openslinputenqueue branch February 24, 2023 00:55
@robertwu1 robertwu1 deleted the robertwu/openslinputenqueue branch February 24, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGSEGV at AudioStreamOpenSLES.cpp - Line 295
2 participants
@robertwu1 @philburk