Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -positive_percentages flag #365

Merged
merged 1 commit into from
May 1, 2018

Conversation

nolanmar511
Copy link
Contributor

This is a step in implementing changes described in #323

@nolanmar511 nolanmar511 force-pushed the remove-positive-percentages branch from b9b87f9 to 1422200 Compare April 26, 2018 23:40
@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #365 into master will increase coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   66.68%   66.68%   +<.01%     
==========================================
  Files          36       36              
  Lines        7457     7454       -3     
==========================================
- Hits         4973     4971       -2     
+ Misses       2082     2081       -1     
  Partials      402      402
Impacted Files Coverage Δ
internal/driver/commands.go 44.5% <ø> (ø) ⬆️
internal/driver/driver.go 70.27% <100%> (-0.16%) ⬇️
internal/report/report.go 30.35% <66.66%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be265fa...6b6c536. Read the comment docs.

@nolanmar511 nolanmar511 requested a review from aalexand April 27, 2018 15:32
@nolanmar511 nolanmar511 force-pushed the remove-positive-percentages branch from 1422200 to 6b6c536 Compare April 30, 2018 17:02
@aalexand aalexand merged commit 3b0df83 into google:master May 1, 2018
KISSMonX pushed a commit to KISSMonX/pprof that referenced this pull request Jun 14, 2018
* 'master' of github.com:google/pprof: (32 commits)
  record diff base profile label key/value constant (google#384)
  apply additional command overrides based on report format (google#381)
  profile: fix legacy format Go heap profile parsing (google#382)
  add -diff flag for better profile comparision (google#369)
  Use -u flag in pprof installation command so that it updates if needed. (google#376)
  Add GetBase support for ASLR kernel mappings (google#371)
  Add show_from profile filter. (google#372)
  Update README.md due to 8dff45d (google#375)
  Remove stale docs, move useful ones. (google#374)
  internal/driver: skip tests requiring tcp on js (google#373)
  Add "trim path" option which can be used to relocate sources. (google#366)
  Move update_d3flamegraph.sh script from the root directory. (google#370)
  Skip unsymbolizable mapping during symbolz pass. (google#368)
  remove -positive_percentages flag (google#365)
  Render icicle graph in "Flame Graph" view (google#367)
  Add command-line editing support for interactive pprof (google#362)
  Improve profile filter unit tests, fix show filtering of mappings (google#354)
  Fake mappings should be merged into a single one during merging (google#357)
  Hack the code so that both existing Go versions and current Go master format it the same (google#358)
  moved filter tests into their own test file which matches the implementation file, filter.go. (google#356)
  ...
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants