internal/driver: skip tests requiring tcp on js #373
Conversation
This commit upstreams the changes made in golang.org/cl/110096. As the change says, it is acceptable for the new js/wasm target to only support what nacl supports right now.
|
/cc @neelance @hyangah @aalexand This change is in preparation for updating the vendored pprof. Otherwise, this patch might have been reverted at some point in the future. Also note that the original change disabled two tests, but I can see three "tcp available" skips. So I've done it for all three to be consistent. |
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 66.73% 66.73%
=======================================
Files 36 36
Lines 7462 7462
=======================================
Hits 4980 4980
Misses 2080 2080
Partials 402 402Continue to review full report at Codecov.
|
|
My bad for forgetting to fetch the latest HEAD. Hopefully you won't leave a merge commit in the master commit history :) |
|
Also - I'd like to wait for @neelance's OK on me skipping a third test. Perhaps the original patch was correct and mine isn't. |
|
Yes, also skipping the third test is correct. Thanks for bringing these changes upstream, should have done so myself. I disabled the tests while working on the support for WebAssembly and forgot about them. |
* 'master' of github.com:google/pprof: (32 commits) record diff base profile label key/value constant (google#384) apply additional command overrides based on report format (google#381) profile: fix legacy format Go heap profile parsing (google#382) add -diff flag for better profile comparision (google#369) Use -u flag in pprof installation command so that it updates if needed. (google#376) Add GetBase support for ASLR kernel mappings (google#371) Add show_from profile filter. (google#372) Update README.md due to 8dff45d (google#375) Remove stale docs, move useful ones. (google#374) internal/driver: skip tests requiring tcp on js (google#373) Add "trim path" option which can be used to relocate sources. (google#366) Move update_d3flamegraph.sh script from the root directory. (google#370) Skip unsymbolizable mapping during symbolz pass. (google#368) remove -positive_percentages flag (google#365) Render icicle graph in "Flame Graph" view (google#367) Add command-line editing support for interactive pprof (google#362) Improve profile filter unit tests, fix show filtering of mappings (google#354) Fake mappings should be merged into a single one during merging (google#357) Hack the code so that both existing Go versions and current Go master format it the same (google#358) moved filter tests into their own test file which matches the implementation file, filter.go. (google#356) ...
This commit upstreams the changes made in golang.org/cl/110096. As the change says, it is acceptable for the new js/wasm target to only support what nacl supports right now.
This commit upstreams the changes made in golang.org/cl/110096. As the
change says, it is acceptable for the new js/wasm target to only support
what nacl supports right now.