Reduce the API of proto-lens-protoc. #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we exposed most of the internals as a library, with the hope that they'd be useful for plugins (i.e. for services). But now we're exposing service information at the type level, and the library continues to be unused. Removing most of it allows us to change the internals without requiring a major version bump. For example, with this change the migration to ghc-source-gen would have only required a minor version bump. Fixes #347. I think it's not feasible to completely remove the library at this time, since we still want to share logic around module names between proto-lens-protoc and proto-lens-setup.
|
Did you search hackage for reverse deps to declare the library unused in practice? |
blackgnezdo
approved these changes
Oct 23, 2019
|
Yeah, they're all only using it for the codegen, not for libraries. |
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
Previously we exposed most of the internals as a library, with the hope that they'd be useful for plugins (i.e. for services). But now we're exposing service information at the type level, and the library continues to be unused. Removing most of it allows us to change the internals without requiring a major version bump. For example, with this change the migration to ghc-source-gen would have only required a minor version bump. Fixes google#347. I think it's not feasible to completely remove the library at this time, since we still want to share logic around module names between proto-lens-protoc and proto-lens-setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we exposed most of the internals as a library, with the hope
that they'd be useful for plugins (i.e. for services). But now we're
exposing service information at the type level, and the library
continues to be unused. Removing most of it allows us to change
the internals without requiring a major version bump. For example,
with this change the migration to ghc-source-gen would have only
required a minor version bump.
Fixes #347. I think it's not feasible to completely remove the library
at this time, since we still want to share logic around module
names between proto-lens-protoc and proto-lens-setup.