Remove the library from proto-lens-protoc #347
Comments
judah
added a commit
that referenced
this issue
Oct 23, 2019
Previously we exposed most of the internals as a library, with the hope that they'd be useful for plugins (i.e. for services). But now we're exposing service information at the type level, and the library continues to be unused. Removing most of it allows us to change the internals without requiring a major version bump. For example, with this change the migration to ghc-source-gen would have only required a minor version bump. Fixes #347. I think it's not feasible to completely remove the library at this time, since we still want to share logic around module names between proto-lens-protoc and proto-lens-setup.
judah
added a commit
that referenced
this issue
Oct 23, 2019
Previously we exposed most of the internals as a library, with the hope that they'd be useful for plugins (i.e. for services). But now we're exposing service information at the type level, and the library continues to be unused. Removing most of it allows us to change the internals without requiring a major version bump. For example, with this change the migration to ghc-source-gen would have only required a minor version bump. Fixes #347. I think it's not feasible to completely remove the library at this time, since we still want to share logic around module names between proto-lens-protoc and proto-lens-setup.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this issue
Aug 9, 2023
Previously we exposed most of the internals as a library, with the hope that they'd be useful for plugins (i.e. for services). But now we're exposing service information at the type level, and the library continues to be unused. Removing most of it allows us to change the internals without requiring a major version bump. For example, with this change the migration to ghc-source-gen would have only required a minor version bump. Fixes google#347. I think it's not feasible to completely remove the library at this time, since we still want to share logic around module names between proto-lens-protoc and proto-lens-setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
proto-lens-protoc exposes an internal library, which has not been used in practice. It limits our ability to make changes inside of it without requiring a major version bump.
Currently the library serves another purpose, namely, to make proto-lens-setup "depend: on the proto-lens-protoc executable (via the dep on the library). However, that doesn't work with cabal new-build.
We should just remove the library (and proto-lens-setup's dependency on it), and require using build-tool-depends instead as in #212.
The text was updated successfully, but these errors were encountered: