-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the "Top cities driving traffic" key metric widget tile #6252
Comments
ACs 👍🏻 Moving this to IB. |
IB ✔️ |
@nfmohit, I have moved it back to execution to apply the changes @sigal-teller provided for the non-interactive plain text. |
QA Update
|
Hey @mohitwp, the short answer here re. the data consistency is that you need to add a hostname filter in your report, to match the default hostname filter that is applied to all of our Analytics reports. Every Analytics report is automatically filtered for the hostname dimension to only return rows matching the hostname or its The main GA4 property we use for So, please can you update your report by adding a hostname filter to match |
@techanvil @hussain-t I added dimension hostname and getting the same numbers in result. |
Hi @mohitwp, thanks for checking. Apologies, I should have sounded a bit less certain in my previous comment - I've been looking into the GA4 data inconsistencies for #7214, and this is the reason for the discrepancy with other It does appear to be a different situation here and it's not yet evident what the cause is. Seeing as this issue has been implemented as per the spec, I'd suggest we add this tile to the AC for #7214 where I can continue to investigate it further, and we can move this one to Approval. |
Thanks for jumping in and providing the information, @techanvil 👍 |
QA Update ✅Thank you @techanvil !
|
Feature Description
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
totalUsers
should be displayed from the Google Analytics Data API using the following metric/dimension and the global date range selected on the Site Kit dashboard:totalUsers
city
Implementation Brief
assets/js/modules/analytics-4/components/widgets/TopCitiesWidget.js
:null
if theGA4
module is not connected.getKeyMetrics
selector, check if any of the selected Metric is from GA4. If not, returnnull
. Otherwise, continue.MetricTileTable
reusable component.totalUsers
city
3
city
(descending)getReport
selector with the metric and dimension as mentioned above.core/user
data store via thegetDateRangeDates
withcompare
set totrue
.totals[0].metricValues
and the value for each city.numFmt
function fromassets/js/util/i18n.js
to format the % number.AnalyticsTopCitiesWidget
inassets/js/modules/analytics-4/components/widgets/AnalyticsTopCitiesWidget.stories.js
.Test Coverage
TopCitiesWidget
component.QA Brief
userInput
feature flag enabled, answer the questionnaire. As part of this issue, test the design and metric values of theTop Cities Widget
widget rendered in the Key Metrics section.Top Cities Widget
widget, run the following code on the browser console:Top Cities Widget
stories within the Key Metrics widget section in the Storybook.Changelog entry
The text was updated successfully, but these errors were encountered: