Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekick image very small on GA4 dashboard prompt banner #6920

Closed
mxbclang opened this issue Apr 19, 2023 · 5 comments
Closed

Sidekick image very small on GA4 dashboard prompt banner #6920

mxbclang opened this issue Apr 19, 2023 · 5 comments
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature

Comments

@mxbclang
Copy link

mxbclang commented Apr 19, 2023

Description

As reported by @bethanylang and @hussain-t in Bug Bash:

The sidekick image on the GA4 dashboard prompt banner is very small on multiple screen sizes:

image

1280x1040

image

1920x1080


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The WinImageSVG (ga4-success-green) image on the SwitchGA4DashboardViewNotification component should be displayed larger to match the Figma design.
  • It should be hidden on smaller (mobile) screens.
  • The image display and hiding behavior should be implemented similarly to the GA4 SuccessBanner component.

Implementation Brief

In assets/js/components/notifications/SwitchGA4DashboardViewNotification.js:

  • Pass the GA4SuccessGreenSVG as a functional (component) reference to the WinImageSVG prop like, () => <GA4SuccessGreenSVG />.

Test Coverage

  • No new tests are to be added.

QA Brief

  • Set up Site Kit.
  • Without the ga4Reporting feature flag enabled, set up the Analytics module with both UA and GA4.
  • Enable the ga4Reporting feature flag.
  • Go to the Site Kit dashboard and observe the "Switch to GA4 Dashboard View" banner notification.
  • Verify that the sidekick image is larger according to the Figma designs mentioned in the ACs.

Changelog entry

  • Fix the svg image size issue on the "Switch to GA4 Dashboard View" banner.
@mxbclang mxbclang added P1 Medium priority Type: Enhancement Improvement of an existing feature Module: Analytics Google Analytics module related issues labels Apr 19, 2023
@hussain-t hussain-t assigned hussain-t and unassigned hussain-t Apr 19, 2023
@eugene-manuilov eugene-manuilov self-assigned this Apr 21, 2023
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Apr 21, 2023
@nfmohit nfmohit self-assigned this Apr 26, 2023
@nfmohit nfmohit removed their assignment Apr 27, 2023
@eugene-manuilov eugene-manuilov self-assigned this Apr 28, 2023
eugene-manuilov added a commit that referenced this issue Apr 28, 2023
Improve sidekick image on "Switch to GA4 Dashboard View" banner notification
@eugene-manuilov eugene-manuilov removed their assignment Apr 28, 2023
@wpdarren wpdarren self-assigned this Apr 28, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented May 1, 2023

QA Update: ⚠️

I have a few questions:

  1. For mobile the decision was to hide the Sidekick image, but on tablet it is still appearing and is small. Do you think we should hide the image on tablets as well?

image

  1. On the figma design there seems to be larger space between the image and the end of the banner. I think it's aligned too far to the right side of the banner. Thoughts welcome on this, but it does look odd alignment on my test site.

My test site:
image

Figma design
image

@tofumatt tofumatt self-assigned this May 1, 2023
@tofumatt
Copy link
Collaborator

tofumatt commented May 1, 2023

@wpdarren I think for tablets the image is fine; we shouldn't be extending the text out that far on tablets anyway for readability, so I think it's fine to add the image there.

What resolution are you using/what is the size of your browser in that screenshot?

Honestly right-aligning it is probably more flexible as the screen grows and I personally prefer it slightly, as otherwise the image feels like it's "floating" in the center a bit to me. But I don't have a strong opinion one way or the other.

I'd probably say this is fine—I think most other images are right-aligned. It also aligns with the right-aligned menu as well.

I think we should leave it as-is for now 🙂

@tofumatt tofumatt removed their assignment May 1, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented May 1, 2023

QA Update: ✅

Verified:

  • The WinImageSVG image on the SwitchGA4DashboardViewNotification component is displayed larger.
  • It is hidden smaller screens but does appear small on tablets.
Screenshots

image
image

@wpdarren wpdarren removed their assignment May 1, 2023
@aaemnnosttv
Copy link
Collaborator

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants