-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidekick image very small on GA4 dashboard prompt banner #6920
Comments
IB ✔️ |
Improve sidekick image on "Switch to GA4 Dashboard View" banner notification
QA Update:
|
@wpdarren I think for tablets the image is fine; we shouldn't be extending the text out that far on tablets anyway for readability, so I think it's fine to add the image there. What resolution are you using/what is the size of your browser in that screenshot? Honestly right-aligning it is probably more flexible as the screen grows and I personally prefer it slightly, as otherwise the image feels like it's "floating" in the center a bit to me. But I don't have a strong opinion one way or the other. I'd probably say this is fine—I think most other images are right-aligned. It also aligns with the right-aligned menu as well. I think we should leave it as-is for now 🙂 |
LGTM 👍 |
Description
As reported by @bethanylang and @hussain-t in Bug Bash:
The sidekick image on the GA4 dashboard prompt banner is very small on multiple screen sizes:
1280x1040
1920x1080
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
WinImageSVG
(ga4-success-green
) image on theSwitchGA4DashboardViewNotification
component should be displayed larger to match the Figma design.SuccessBanner
component.Implementation Brief
In
assets/js/components/notifications/SwitchGA4DashboardViewNotification.js
:GA4SuccessGreenSVG
as a functional (component) reference to theWinImageSVG
prop like,() => <GA4SuccessGreenSVG />
.Test Coverage
QA Brief
ga4Reporting
feature flag enabled, set up the Analytics module with both UA and GA4.ga4Reporting
feature flag.Changelog entry
The text was updated successfully, but these errors were encountered: