Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidekick image on "Switch to GA4 Dashboard View" banner notification #6987

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

nfmohit
Copy link
Collaborator

@nfmohit nfmohit commented Apr 26, 2023

Summary

Addresses issue:

Relevant technical choices

This PR improves the size of the sidekick image on "Switch to GA4 Dashboard View" banner notification.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

Size Change: +3 B (0%)

Total Size: 1.24 MB

Filename Size Change
./dist/assets/js/googlesitekit-main-dashboard-********************.js 75 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 48.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.41 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 22.6 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 31.8 kB
./dist/assets/js/googlesitekit-api-********************.js 9.59 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.12 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 9.73 kB
./dist/assets/js/googlesitekit-data-********************.js 2.17 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.22 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 16.3 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.3 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.6 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 63.4 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 73.3 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 28.6 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 83.6 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.3 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 19 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.3 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 50.2 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.7 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-settings-********************.js 47.1 kB
./dist/assets/js/googlesitekit-splash-********************.js 65.3 kB
./dist/assets/js/googlesitekit-user-input-********************.js 39.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js 319 kB
./dist/assets/js/googlesitekit-widgets-********************.js 16.6 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.4 kB
./dist/assets/js/runtime-********************.js 1.26 kB

compressed-size-action

@eugene-manuilov eugene-manuilov merged commit 0247304 into develop Apr 28, 2023
@eugene-manuilov eugene-manuilov deleted the enhancement/#6920-sidekick-image branch April 28, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants