Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive module state on page load only #4141

Closed
wants to merge 4 commits into from

Conversation

aaemnnosttv
Copy link
Collaborator

Summary

Addresses issue #2796

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@github-actions
Copy link

Size Change: -103 B (0%)

Total Size: 1.09 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules.********************.js 16.4 kB -4 B (0%)
./dist/assets/js/googlesitekit-settings.********************.js 49.6 kB -99 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/js/33.********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-activation.********************.js 38.6 kB
./dist/assets/js/googlesitekit-adminbar.********************.js 31.4 kB
./dist/assets/js/googlesitekit-api.********************.js 9.04 kB
./dist/assets/js/googlesitekit-base.********************.js 1.59 kB
./dist/assets/js/googlesitekit-dashboard-details.********************.js 45 kB
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 52.7 kB
./dist/assets/js/googlesitekit-dashboard.********************.js 45.3 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.74 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.2 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.71 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 20.9 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 23.8 kB
./dist/assets/js/googlesitekit-module.********************.js 45 kB
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.9 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 18.8 kB
./dist/assets/js/googlesitekit-modules-analytics.********************.js 66.4 kB
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 24.2 kB
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.3 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.4 kB
./dist/assets/js/googlesitekit-modules-subscribe-with-google.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 29.9 kB
./dist/assets/js/googlesitekit-polyfills.********************.js 379 B
./dist/assets/js/googlesitekit-user-input.********************.js 45.7 kB
./dist/assets/js/googlesitekit-vendor.********************.js 312 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.4 kB
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 33.5 kB
./dist/assets/js/runtime.********************.js 1.19 kB

compressed-size-action

@eugene-manuilov
Copy link
Collaborator

Didn't notice that this PR has been created and created #4298. We probably need to put all links to existing PRs as the first line of IB to avoid missing it again 😄

Closing this in favor of the new PR.

@tofumatt tofumatt deleted the fix/2796-module-state-changes branch October 31, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants