Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/2796 module state #4298

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Bug/2796 module state #4298

merged 4 commits into from
Nov 2, 2021

Conversation

eugene-manuilov
Copy link
Collaborator

Summary

Addresses issue #2796

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Size Change: +6.62 kB (+1%)

Total Size: 1.18 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.css 38.7 kB +11 B (0%)
./dist/assets/css/googlesitekit-adminbar-css-********************.css 8.02 kB +17 B (0%)
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.css 4.59 kB +11 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js 39.6 kB -22 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 31.7 kB -77 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.16 kB -11 B (0%)
./dist/assets/js/googlesitekit-base-********************.js 1.58 kB -1 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js 47.2 kB +425 B (+1%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js 46.5 kB -127 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 54.1 kB -196 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.89 kB +13 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.02 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 13.3 kB -9 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 8.83 kB +15 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 21 kB -78 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 24.2 kB +51 B (0%)
./dist/assets/js/googlesitekit-module-********************.js 45.6 kB +27 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 16.6 kB -21 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 61.4 kB +99 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 18.8 kB -155 B (-1%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 70 kB -355 B (-1%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 24.6 kB -6 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js 18.5 kB -39 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 17 kB -32 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 36.3 kB +6.95 kB (+24%) 🚨
./dist/assets/js/googlesitekit-modules-subscribe-with-google-********************.js 16.9 kB -25 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 29.7 kB +14 B (0%)
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B -1 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 50.5 kB +99 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 46.6 kB +20 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 12.8 kB -17 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 34.1 kB +35 B (0%)
./dist/assets/js/runtime-********************.js 1.19 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/js/33-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-data-********************.js 1.65 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 2.4 kB
./dist/assets/js/googlesitekit-vendor-********************.js 312 kB

compressed-size-action

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we can clarify the text in the datastore comment.

Can you add a QA Brief as well? Then this should be good-to-go 👍🏻

assets/js/googlesitekit/modules/datastore/modules.js Outdated Show resolved Hide resolved
Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great 👍🏻

@tofumatt tofumatt merged commit 9a6ad27 into develop Nov 2, 2021
@tofumatt tofumatt deleted the bug/2796-module-state branch November 2, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants