Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincode 1.0.0-alpha6 changed SizeLimit to a trait #134

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Conversation

ms705
Copy link
Contributor

@ms705 ms705 commented Mar 19, 2017

Unfortunately, cargo's semantic versioning gets confused by the -alpha suffix in current bincode versions (I think): even though tarpc's Cargo.toml specified version 1.0.0-alpha4, cargo will download the more recent 1.0.0-alpha6, which has breaking changes to the SizeLimit enum.

This change makes tarpc work with bincode 1.0.0-alpha6 and updates the dependency.

Fixes #133 for me.

Unfortunately, cargo's semantic versioning gets confused by the
"-alpha" suffix in current bincode versions (I think): even though
tarpc's Cargo.toml specified version "1.0.0-alpha4", cargo will
download the more recent "1.0.0-alpha6", which has breaking changes
to the `SizeLimit` enum.

This change makes tarpc work with bincode 1.0.0-alpha6 and updates the
dependency.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tikue
Copy link
Collaborator

tikue commented Mar 19, 2017

Thanks! Looks like there are Travis failures?

@ms705
Copy link
Contributor Author

ms705 commented Mar 19, 2017

Those are due to cargo #3844, and hopefully fixed in the latest nightly!

@ms705
Copy link
Contributor Author

ms705 commented Mar 19, 2017

(Also, I signed the CLA.)

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@tikue tikue merged commit f4018a4 into google:master Mar 19, 2017
@tikue
Copy link
Collaborator

tikue commented Mar 19, 2017

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures with recent nightlies (due to bincode?)
3 participants