Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo version unwraps None #3844

Closed
anna-is-cute opened this issue Mar 18, 2017 · 16 comments
Closed

cargo version unwraps None #3844

anna-is-cute opened this issue Mar 18, 2017 · 16 comments

Comments

@anna-is-cute
Copy link

anna-is-cute commented Mar 18, 2017

RUST_BACKTRACE=full cargo version results in this. That backtrace is from macOS 10.12.4 beta.

I have verified this issue exists on both macOS and Arch. Arch backtrace.

@TyOverby
Copy link

currently failing on travis

https://travis-ci.org/TyOverby/bincode/jobs/212339208

@anna-is-cute
Copy link
Author

I found #3819, but it looks like that was supposed to be fixed, and this issue still persists in rustc 1.17.0-nightly (a559452b0 2017-03-17).

@NoraCodes
Copy link

Also happens for me https://api.travis-ci.org/jobs/212348423/

@SergioBenitez
Copy link
Contributor

😢

@alexcrichton
Copy link
Member

Fixed in rust-lang/rust#40625

sorry for the breakage!

@wagenet
Copy link

wagenet commented Mar 18, 2017

Is there a temporary workaround for this? It's killing all of our CI tests.

@abonander
Copy link

I've disabled the nightly branch in my Travis config for the time being, otherwise I don't know.

@diggyk
Copy link

diggyk commented Mar 18, 2017

I need nightly to do my build. How long does a fix like this make it into nightly?

@abonander
Copy link

It's been approved as high-priority so it should merge tonight, but then there's rollup merging and testing and that takes a day or two to go through (unless high-priority PRs skip rollups), so maybe Monday's nightly?

@Arnavion
Copy link

Usually one configures travis to ignore failures on nightly. If your code only builds with nightly, then you might want to consider pinning it to a known good version. It's nightly after all; it can break.

frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@TomasTomecek
Copy link

@Arnavion

If your code only builds with nightly, then you might want to consider pinning it to a known good version.

Is there a guide how to do that?

@Arnavion
Copy link

The version of rust you specify in .travis.yml is just passed to rustup, so anything rustup accepts will work. Eg nightly-2017-03-16 will install the nightly released on 2017-03-16.

@gaurikholkar-zz
Copy link

frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@wagenet
Copy link

wagenet commented Mar 18, 2017

Ah whoops, I was pinning my Rust version but wasn't going far enough back in time. Strange that it didn't start happening until yesterday. I wonder if it is somehow a twofold failure. Anyway it seems like the team has it under control :)

@lilianmoraru
Copy link

lilianmoraru commented Mar 18, 2017

Similar issue with Windows a few days ago... :)

Temporary fix if you don't want to disable nightly testing:

rustup toolchain add nightly-2017-03-16
cargo +nightly-2017-03-16 build

bors added a commit to rust-lang/rust that referenced this issue Mar 18, 2017
Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 18, 2017
…alexcrichton

Update the cargo submodule again

Unfortunately it was reverted back to a broken state in
e06c515 by accident, so let's bring it forward
again!

Closes rust-lang/cargo#3844
@TomasTomecek
Copy link

@Arnavion thank you: I wasn't using rustup, instead I used to download tarballs manually. Switching to rustup now then. For anyone interested, here's an url of nightly, based on @Arnavion suggestion, which works:

https://static.rust-lang.org/dist/2017-03-16/rust-nightly-x86_64-unknown-linux-gnu.tar.gz

Full command in my Dockerfile:

ARG RUST_CHANNEL="nightly-2017-03-16"
RUN curl -s https://static.rust-lang.org/rustup.sh | sh -s -- --spec=$RUST_CHANNEL --verbose --disable-sudo

mjc-gh added a commit to mjc-gh/message_verifier that referenced this issue Mar 18, 2017
yrashk referenced this issue in PumpkinDB/PumpkinDB Mar 18, 2017
```
$ cargo --version
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /checkout/src/libcore/option.rs:323
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
```

Solution: switch to nightly-2017-03-14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests