Add ApexChart based visualizations #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sydp This is a big PR :) It will take some time to review. I'll catch up with you offline to see if we can break it up a bit. |
jkppr
reviewed
May 21, 2024
timesketch/frontend-ng/src/components/LeftPanel/Visualizations.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/SavedVisualization.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/VisualizationEditor.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/AggregationConfig.vue
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/ChartConfig.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/VisualizationEditor.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/VisualizationEditor.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/AggregationConfig.vue
Outdated
Show resolved
Hide resolved
….vue Co-authored-by: Janosch <99879757+jkppr@users.noreply.github.com>
…lization.vue Co-authored-by: Janosch <99879757+jkppr@users.noreply.github.com>
jkppr
reviewed
May 23, 2024
timesketch/frontend-ng/src/components/Visualization/AggregationConfig.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/ChartColumn.vue
Outdated
Show resolved
Hide resolved
timesketch/frontend-ng/src/components/Visualization/AggregationConfig.vue
Outdated
Show resolved
Hide resolved
…nConfig.vue Co-authored-by: Janosch <99879757+jkppr@users.noreply.github.com>
|
I'm not able to comment to this in thread but this seems to be working as intended on my machine. perhaps it could be stale data after changing the max document count value. does clicking the "load button" produce the expected data? edit: disregard, I think i am able to replicate. seems the value isn't propagating. |
Adjusting the agg UI following latest UX mocks
jkppr
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ApexChart based visualizations to frontend-ng
Checks
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes(if such).
cast.webm