Adjusting the agg UI following latest UX mocks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydp
reviewed
Jul 15, 2024
| @@ -347,8 +373,10 @@ export default { | |||
| this.selectedYTitle = this.yTitle | |||
| }, | |||
| saveVisualization() { | |||
| if (this.selectedChartTitle === "New Visualization") { | |||
| this.selectedChartTitle = prompt("Please enter a name for the visualization:") | |||
There was a problem hiding this comment.
if cancel is clicked during this prompt it results in a null value being assigned to selectedChartTitle which causes an error when rendering the LHS menu. I'll add a fix/check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I invested some time to adjust the UI following the latest mocks from UX we talked about.
I'm not pushing them directly to the PR google#3040 so you can take a look / review them first if everything works. If you merge them here, they should automatically be merged to the PR as well.