Logon sessions sketch analyzer #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes made to testlib.py to support our testing.
-Added BaseExpertSessionizerPlugin as a base class for the expert sessionizers. -Added WebActivitySessionizerSketchPlugin -Changed sessionizer.py so that the attributes for non-expert sessioned events follows the same format as expert sessioned ones. -Updated sessionizer_tests.py to reflect this.
…imesketch into expert-sessionizer
- Base class for sessionizer tests - Test for the type of events processed by WebActivitySessionizerSketchPlugin - _create_mock_event changed to accept custom attributes for the event source
Minor changes to sessionizer.py, base_sessionizer_test.py and expert_sessonizers_test.py to be compatible with the new functionality.
-Removes dependency on xml parsing library -Changes to tests to fix linting issues
|
Closing this pull request and opening another updated version. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to issue #955