Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evtx sessionizer #976

Merged
merged 22 commits into from
Feb 5, 2020
Merged

Evtx sessionizer #976

merged 22 commits into from
Feb 5, 2020

Conversation

katemacleod
Copy link
Contributor

Replaces previous pull request #964 (changes to tests needed to be made for compatibility with other changes. These tests would be overwritten by this pull request anyway). Solution for issues #955 and #952

Kate Macleod added 7 commits August 27, 2019 12:12
-Logon sessions analyzer
-Unlock sessions analyzer
-Renaming annotateEvent in sessionizer.py to addSessionId
-Compatibility for new method of adding events to MockDataStore
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 4, 2020
@tomchop tomchop added cla: yes and removed cla: no labels Feb 5, 2020
@tomchop
Copy link
Collaborator

tomchop commented Feb 5, 2020

Manually setting CLA to yes because we rebased from the GitHub UI

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@tomchop tomchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a few style nits, otherwise LGTM

@tomchop tomchop merged commit bbfe7cc into google:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants