-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace get event in tests #980
Conversation
Contains the changes in pull request google#980
Includes the changes in pull request google#980
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor changes, but otherwise LGTM
* Required for merging * Required for merging * Required for merging * Sessionizers for WIndows EVTX logs -Logon sessions analyzer -Unlock sessions analyzer -Renaming annotateEvent in sessionizer.py to addSessionId -Compatibility for new method of adding events to MockDataStore * Removed stray comments * renaming addSessionId -> annotateEvent for compatibility * Removing multiple inheritance in tests * Replacing get event in tests Contains the changes in pull request #980 * Pylint fixes * Fix some whitespace issues * Remove newline * Remove newline * Remove unnecessary changes * Fix style a bit Co-authored-by: Thomas Chopitea <tomchop@gmail.com>
* Required for merging * Required for merging * Required for merging * Add SSH bruteforce analyzer to expert_sessionizers.py * Adding missing docstring * Updating tests for compatibility with MockDataStore fix * Pylint fixes * Pylint fixes * Removing multiple inheritance for tests Includes some of the changes made in pull request #977 in order to make tests pass. -Remove multiple inheritance for TestSSHBruteforceSessionizerPlugin in expert_sessionizers_test.py -Add ssh bruteforce sessionizer to list in base_sessionizer_test.py * Replacing get event in tests Includes the changes in pull request #980 * Pylint fixes * Fix nit * Linter issues Co-authored-by: Thomas Chopitea <tomchop@gmail.com> Co-authored-by: Johan Berggren <jberggren@gmail.com>
This pull request depends on #977.