Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the TrillianLog.GetLeavesByHash API #2243

Merged
merged 2 commits into from
Mar 19, 2021
Merged

remove the TrillianLog.GetLeavesByHash API #2243

merged 2 commits into from
Mar 19, 2021

Conversation

pphaneuf
Copy link
Contributor

@pphaneuf pphaneuf commented Oct 22, 2020

Remove the TrillianLog.GetLeavesByHash API, as it is unused.

This is part of #2245.

Checklist

@pphaneuf pphaneuf requested review from AlCutter, Martin2112 and a team as code owners October 22, 2020 18:34
@google-cla google-cla bot added the cla: yes label Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #2243 (b5ab878) into master (9d9c7c9) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   65.47%   65.29%   -0.18%     
==========================================
  Files         104      104              
  Lines        7511     7475      -36     
==========================================
- Hits         4918     4881      -37     
- Misses       2074     2075       +1     
  Partials      519      519              
Impacted Files Coverage Δ
server/interceptor/interceptor.go 83.08% <ø> (+1.22%) ⬆️
server/log_rpc_server.go 82.95% <ø> (-1.12%) ⬇️
server/validate.go 93.33% <ø> (-0.52%) ⬇️
client/log_client.go 70.93% <0.00%> (-1.17%) ⬇️
log/operation_manager.go 87.30% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9c7c9...b5ab878. Read the comment docs.

@pphaneuf pphaneuf requested a review from mhutchinson February 6, 2021 00:30
@pphaneuf pphaneuf removed the request for review from mhutchinson February 17, 2021 11:29
Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment nit

README.md Outdated Show resolved Hide resolved
@pphaneuf pphaneuf merged commit 1222c48 into google:master Mar 19, 2021
@pphaneuf pphaneuf deleted the getleavesbyhash branch March 19, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants