-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strip out unused and unneeded code #2245
Labels
Comments
This was referenced Oct 23, 2020
This was referenced Feb 8, 2021
This was referenced Mar 22, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 22, 2021
This was referenced Mar 22, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 23, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 23, 2021
There's only one hasher to register, as a first step, simply verify that it is the hasher requested, and return it. Part of #2245.
pphaneuf
added a commit
that referenced
this issue
Mar 23, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 23, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 24, 2021
This was referenced Mar 30, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 30, 2021
pphaneuf
added a commit
that referenced
this issue
Mar 30, 2021
2 tasks
pphaneuf
added a commit
that referenced
this issue
Mar 30, 2021
pphaneuf
added a commit
that referenced
this issue
Apr 6, 2021
This was referenced Apr 8, 2021
Merged
pphaneuf
added a commit
that referenced
this issue
Apr 9, 2021
2 tasks
pphaneuf
added a commit
that referenced
this issue
Apr 9, 2021
This was referenced May 18, 2021
pphaneuf
added a commit
that referenced
this issue
May 18, 2021
2 tasks
pphaneuf
added a commit
that referenced
this issue
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A number of APIs (both external and internal) add burden to storage implementers, without bringing much benefits.
For example,
QueueLeaves
is complex to implement correctly, due to being a batching API with partial failure, but in practice, there are possibly no need for it, and due to the implementation complexity, is very unlikely to provide any performance benefit over usingQueueLeaf
(the non-batch version of this API) multiple times (potentially concurrently), say, and this both leaves the user in better control over what happens in the partial failure cases, and removes complexity of implementation (and the inevitable bugs that it brings).The text was updated successfully, but these errors were encountered: