Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some unused glue code. #2332

Merged
merged 2 commits into from
Feb 16, 2021
Merged

remove some unused glue code. #2332

merged 2 commits into from
Feb 16, 2021

Conversation

pphaneuf
Copy link
Contributor

@pphaneuf pphaneuf commented Feb 5, 2021

This is part of #2245.

Checklist

@pphaneuf pphaneuf requested a review from a team as a code owner February 5, 2021 21:06
@pphaneuf pphaneuf requested a review from NatalieDoduc February 5, 2021 21:06
@pphaneuf pphaneuf requested review from AlCutter and removed request for NatalieDoduc February 5, 2021 21:07
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #2332 (e6ad361) into master (ec49bee) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
+ Coverage   65.90%   65.96%   +0.05%     
==========================================
  Files         106      105       -1     
  Lines        7749     7745       -4     
==========================================
+ Hits         5107     5109       +2     
+ Misses       2106     2100       -6     
  Partials      536      536              
Impacted Files Coverage Δ
crypto/signer.go 88.00% <ø> (+9.42%) ⬆️
log/operation_manager.go 89.41% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec49bee...e6ad361. Read the comment docs.

@pphaneuf
Copy link
Contributor Author

PTAL?

Copy link
Contributor

@NatalieDoduc NatalieDoduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit could you reword the commit to explicitly say "Removed the deprecated crypto.NewSHA256Signer function."

@pphaneuf
Copy link
Contributor Author

Done.

@pphaneuf pphaneuf merged commit 0aa1890 into google:master Feb 16, 2021
@pphaneuf pphaneuf deleted the deprecated branch February 16, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants