Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetSequencedLeafCount from the storage interface. #2439

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Remove GetSequencedLeafCount from the storage interface. #2439

merged 1 commit into from
Mar 30, 2021

Conversation

pphaneuf
Copy link
Contributor

Part of #2245.

Checklist

@pphaneuf pphaneuf requested a review from a team as a code owner March 30, 2021 17:02
@pphaneuf pphaneuf requested a review from mhutchinson March 30, 2021 17:02
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2439 (69136d4) into master (ba7a41b) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2439      +/-   ##
==========================================
+ Coverage   65.89%   66.03%   +0.14%     
==========================================
  Files         104      104              
  Lines        7240     7223      -17     
==========================================
- Hits         4771     4770       -1     
+ Misses       1953     1939      -14     
+ Partials      516      514       -2     
Impacted Files Coverage Δ
storage/cloudspanner/log_storage.go 56.11% <ø> (+0.43%) ⬆️
storage/memory/log_storage.go 3.77% <ø> (+0.13%) ⬆️
storage/mysql/log_storage.go 65.95% <ø> (-0.09%) ⬇️
client/log_client.go 77.48% <0.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba7a41b...69136d4. Read the comment docs.

@pphaneuf pphaneuf requested review from AlCutter and pav-kv March 30, 2021 17:25
@pphaneuf pphaneuf merged commit ffe0cdc into google:master Mar 30, 2021
@pphaneuf pphaneuf deleted the getsequencedleafcount branch March 30, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants