Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions workflow #12

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Fix GitHub actions workflow #12

merged 4 commits into from
Feb 28, 2024

Conversation

MarinaZhang
Copy link
Collaborator

@MarinaZhang MarinaZhang commented Feb 22, 2024

GitHub actions workflow for installing/mypy failing. To fix, this PR does

  • bump min version to python 3.10 (not 3.9, which doesn't work)
  • add python3 -m pip install types-tabulate before running mypy

Note: testing for python 3.12 also was failing due to onnxruntime not supporting python 3.12 until very recently (tf2onnx still does not), will add back the test after it is supported. the UniSim package should still work, but we recommend <3.12

@MarinaZhang MarinaZhang added the bug Something isn't working label Feb 22, 2024
@MarinaZhang MarinaZhang added this to the Alpha Release milestone Feb 22, 2024
@MarinaZhang MarinaZhang self-assigned this Feb 22, 2024
@owenvallis owenvallis merged commit cfced02 into main Feb 28, 2024
4 checks passed
@owenvallis owenvallis deleted the development branch February 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants