Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub actions workflow #12

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Fix GitHub actions workflow #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82e9057
bump min version to python 3.10 and add mypy install stubs
MarinaZhang Feb 22, 2024
8012f23
add just missing tabulate mypy types to workflow
MarinaZhang Feb 22, 2024
c5f58ab
black formatting
MarinaZhang Feb 23, 2024
53ae4a8
remove python 3.12 test becuase tf2onnx does not support 3.12 yet, wi…
MarinaZhang Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12']
python-version: ['3.10', '3.11']

steps:
- uses: actions/checkout@v2
Expand All @@ -36,6 +36,7 @@ jobs:

- name: Static analysis
run: |
python3 -m pip install types-tabulate
mypy unisim/ --raise-exceptions

- name: Test with pytest
Expand Down
2 changes: 1 addition & 1 deletion mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[mypy]
ignore_missing_imports = True
warn_return_any = True
warn_unused_configs = True
warn_unused_configs = True
4 changes: 2 additions & 2 deletions tests/test_textsim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def test_textsim_match_two_lists(backend_type, index_type):
"query": queries,
"target": [targets[3], targets[0], targets[1], targets[2]],
"similarity": [1.0000, 0.9371, 0.8950, 1.000],
"is_match": [True, True, False, True]
"is_match": [True, True, False, True],
}
)
pd.testing.assert_frame_equal(df, expected_df, check_exact=False, atol=1e-4)
Expand All @@ -151,7 +151,7 @@ def test_textsim_match_single_list(backend_type, index_type):
"query": queries,
"target": [queries[1], queries[2], queries[1], queries[0]],
"similarity": [0.7674, 0.9371, 0.9371, 0.3772],
"is_match": [False, True, True, False]
"is_match": [False, True, True, False],
}
)
pd.testing.assert_frame_equal(df, expected_df, check_exact=False, atol=1e-4)
Loading