Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document optimal Nginx config #278

Closed
sindresorhus opened this issue Jul 11, 2014 · 8 comments
Closed

Document optimal Nginx config #278

sindresorhus opened this issue Jul 11, 2014 · 8 comments

Comments

@sindresorhus
Copy link
Contributor

Preferably linking to an existing source.

@sindresorhus
Copy link
Contributor Author

From @pierrebeaucamp

it doesn't make sense to include an nginx config file in WSK itself, as the config should sit somewhere else. Worst case scenario: someone makes their server config public after they just copy the repo without knowing anything about nginx.
I think a note in the docs pointing to https://github.com/h5bp/server-configs-nginx would be the safest and easiest thing to do at the moment.

@passy
Copy link
Collaborator

passy commented Jul 12, 2014

Agreed. Let's link to H5BP.
On Jul 11, 2014 11:00 PM, "Sindre Sorhus" notifications@github.com wrote:

From @pierrebeaucamp https://github.com/pierrebeaucamp

it doesn't make sense to include an nginx config file in WSK itself, as
the config should sit somewhere else. Worst case scenario: someone makes
their server config public after they just copy the repo without knowing
anything about nginx.
I think a note in the docs pointing to
https://github.com/h5bp/server-configs-nginx would be the safest and
easiest thing to do at the moment.


Reply to this email directly or view it on GitHub
#278 (comment)
.

@addyosmani
Copy link
Contributor

👍

@addyosmani
Copy link
Contributor

@sindresorhus I feel like we've discussed this before, but just to check: https://github.com/h5bp/html5-boilerplate/tree/master/doc includes a docs folder in the project directory with docs inline. Do we want to do something similar or are we happy with deferring to the wiki?

@jbnicolai
Copy link
Contributor

@addyosmani deferring to the wiki seems to be the conclusion of the discussion in #275

@sindresorhus
Copy link
Contributor Author

Yup

@addyosmani
Copy link
Contributor

Okay. Let's defer to the wiki for now. Long-term I'd love for us to keep an open mind about the docs directory suggestion still :)

@addyosmani
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants