-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds .htaccess file #275
Adds .htaccess file #275
Conversation
Maybe this was already brought up sometime earlier, but is it necessary to include an apache specific configuration file? I can understand that Apache has a high market share, but in my opinion the choice of the webserver should not be determined by the website itself - web-starter-kit should run on all webservers alike. |
Does adding a |
@addyosmani @sindresorhus I personally think that the usefulness of this addition is highly dependent on what audience you are targeting / you have. The Apache server configs are still included¹ in HTML5 Boilerplate as we have a lot of users that don't know anything about servers and just go with some random hosting services, services that, in most cases, still run Apache. ¹ may change in the future (especially as we get our other server configs up to date and inline with the Apache ones). If you decide to include the Apache server configs, I can say that they are well documented and actively maintained, being up-to-date with the latest additions and changes happening out there (e.g.: 1, 2).
@arthurvr No. |
If adding the file doesn’t break anything on not-apache servers, +1 for adding it to the repo! If users of the starter kit don’t know or don’t need the file, they can remove or just ignore it. |
I guess the question we should be asking, is there any performance benefit of adding it? As adding it automatically means a slight perf decrease:
(no idea how much though) If the above is negligible I guess we could add it for convenience as I know most of our users won't know anything about servers and will most likely use something Apache powered. |
@sindresorhus sure, you get things such as caching, compression, etc., by default. e.g.:
|
I was trying to improve the performance of a WSK project yesterday that I'd just pushed to my domain. Unfortunately, despite all of the tooling we give you out of the box caching is one of those things you're somewhat left to your own devices to figure out. Just by dropping in the .htaccess file with minor reconfiguration, I was able to tick the caching box off and improve my score. I'm 👍 on bringing back in the 404 part. I can do that if we decide to go ahead with this addition. We do want to make sure we're only adding this in if it actually helps people :) I see there being three options for moving forward here:
|
+1 for adding it to the master branch. For not-apache users, the file doesn't make any sense. I think when we put it into another branch, a hole bunch of 'web starters' wouldn't take a look at it. |
@stephenplusplus @gauntface @sindresorhus @passy could we get some votes on +1/-1 for this change? |
@addyosmani given the trend of use for nginx, I just want to make sure that we have that on the plate too at some point. |
Added back the 404 advice in a commented out form. Does LG to folks? @PaulKinlan definitely worth keeping in mind for the future. |
@PaulKinlan can you open a ticket so we don't forget. I agree we should cover the two most popular ones. See: https://github.com/h5bp/server-configs-nginx |
@PaulKinlan and @sindresorhus it doesn't make sense to include an nginx config file in WSK itself, as the config should sit somewhere else. Worst case scenario: someone makes their server config public after they just copy the repo without knowing anything about nginx. |
@pierrebeaucamp yeah, I've never used Nginx before, I just assumed it had a similar configfile. Your suggestion is probably the sane thing to do indeed. |
Are we okay with landing this one and documenting/providing samples for nginx and other configurations outside of the main repo? |
👍 #278 |
reviewer: @sindresorhus