Migrate to pyproject.toml #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Testing shows that this closes #1121 |
bwendling
pushed a commit
that referenced
this pull request
Oct 10, 2023
So while migrating to pyproject.toml fixed editable installation behavior on Ubuntu, Pylance was still unable to figure out imports as vscode does not understand the import script .venv/lib/python3.10/site-packages/__editable___yapf_0_40_2_finder.py created by an editable install triggered by pip install -m venv .venv Using https://microsoft.github.io/pyright/#/import-resolution?id=setuptools suggestions of compat and strict mode did not resolve issues either. So instead I revert to manually adding third_party to the python.analysis.extraPaths setting in settings.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate away from setuptools to pyproject.toml
Attanched output of
diff --recursive --unified .venv-setup.py/ .venv-pyproject.toml/ | grep -v 'Binary files' > venv.diffvenv.diff.txt