Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1131 fix for #1121 did not fix vscode behavior on ubuntu #1149

Merged
merged 2 commits into from
Oct 10, 2023
Merged

#1131 fix for #1121 did not fix vscode behavior on ubuntu #1149

merged 2 commits into from
Oct 10, 2023

Conversation

Spitfire1900
Copy link
Contributor

So while migrating to pyproject.toml fixed editable installation behavior on Ubuntu, Pylance was still unable to figure out imports as vscode does not understand the import script .venv/lib/python3.10/site-packages/__editable___yapf_0_40_2_finder.py created by an editable install triggered by pip install -m venv .venv

Using https://microsoft.github.io/pyright/#/import-resolution?id=setuptools suggestions of compat and strict mode did not resolve issues either.

So instead I revert to manually adding third_party to the python.analysis.extraPaths setting in settings.json

@Spitfire1900
Copy link
Contributor Author

Spitfire1900 commented Oct 7, 2023

@bwendling this is required for development of YAPF on VSCode in Linux, may it be merged?

@bwendling
Copy link
Member

Sorry for the delay. I was on vacation.

@bwendling bwendling merged commit 9953ac9 into google:main Oct 10, 2023
@Spitfire1900 Spitfire1900 deleted the bugfix/vscode-python.analysis.extraPaths branch October 19, 2023 01:08
@Spitfire1900 Spitfire1900 restored the bugfix/vscode-python.analysis.extraPaths branch October 19, 2023 01:08
@Spitfire1900 Spitfire1900 deleted the bugfix/vscode-python.analysis.extraPaths branch October 19, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants