-
Notifications
You must be signed in to change notification settings - Fork 129
BoolValue presence checking #2561
BoolValue presence checking #2561
Conversation
PTAL |
Ran this new jar locally on firestore and it did restore the string formatting methods. |
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
============================================
- Coverage 87.1% 87.09% -0.01%
- Complexity 5524 5525 +1
============================================
Files 466 466
Lines 21797 21797
Branches 2394 2394
============================================
- Hits 18986 18985 -1
- Misses 1942 1943 +1
Partials 869 869
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
============================================
- Coverage 87.1% 87.09% -0.01%
- Complexity 5524 5525 +1
============================================
Files 466 466
Lines 21797 21797
Branches 2394 2394
============================================
- Hits 18986 18985 -1
- Misses 1942 1943 +1
Partials 869 869
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
============================================
- Coverage 87.1% 87.09% -0.01%
- Complexity 5524 5525 +1
============================================
Files 466 466
Lines 21797 21797
Branches 2394 2394
============================================
- Hits 18986 18985 -1
- Misses 1942 1943 +1
Partials 869 869
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we also consider adding tests that confirm this behaviour? (Perhaps in future PR?)
Presence of an object in proto is given by the
has[Object]
method.