Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

BoolValue presence checking #2561

Merged
merged 4 commits into from
Feb 12, 2019

Conversation

andreamlin
Copy link
Contributor

Presence of an object in proto is given by the has[Object] method.

@andreamlin
Copy link
Contributor Author

PTAL

@andreamlin
Copy link
Contributor Author

Ran this new jar locally on firestore and it did restore the string formatting methods.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2561 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2561      +/-   ##
============================================
- Coverage      87.1%   87.09%   -0.01%     
- Complexity     5524     5525       +1     
============================================
  Files           466      466              
  Lines         21797    21797              
  Branches       2394     2394              
============================================
- Hits          18986    18985       -1     
- Misses         1942     1943       +1     
  Partials        869      869
Impacted Files Coverage Δ Complexity Δ
.../google/api/codegen/config/GapicProductConfig.java 76.55% <0%> (-0.48%) 69 <0> (ø)
...api/codegen/config/ResourceNameMessageConfigs.java 92.75% <0%> (+1.44%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec4bb...c074de7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2561 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2561      +/-   ##
============================================
- Coverage      87.1%   87.09%   -0.01%     
- Complexity     5524     5525       +1     
============================================
  Files           466      466              
  Lines         21797    21797              
  Branches       2394     2394              
============================================
- Hits          18986    18985       -1     
- Misses         1942     1943       +1     
  Partials        869      869
Impacted Files Coverage Δ Complexity Δ
.../google/api/codegen/config/GapicProductConfig.java 76.55% <0%> (-0.48%) 69 <0> (ø)
...api/codegen/config/ResourceNameMessageConfigs.java 92.75% <0%> (+1.44%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbec4bb...c074de7. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2561 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2561      +/-   ##
============================================
- Coverage      87.1%   87.09%   -0.01%     
- Complexity     5524     5525       +1     
============================================
  Files           466      466              
  Lines         21797    21797              
  Branches       2394     2394              
============================================
- Hits          18986    18985       -1     
- Misses         1942     1943       +1     
  Partials        869      869
Impacted Files Coverage Δ Complexity Δ
.../google/api/codegen/config/GapicProductConfig.java 76.55% <0%> (-0.48%) 69 <0> (ø)
...api/codegen/config/ResourceNameMessageConfigs.java 92.75% <0%> (+1.44%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4e15e...d8d8c02. Read the comment docs.

Copy link
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we also consider adding tests that confirm this behaviour? (Perhaps in future PR?)

@andreamlin andreamlin merged commit de217ce into googleapis:master Feb 12, 2019
@andreamlin andreamlin deleted the fix_enable_string_format branch February 12, 2019 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants