Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Test enable string format #2564

Merged
merged 14 commits into from
Feb 13, 2019

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 12, 2019

Tests #2561

Blocked on #2563

@andreamlin
Copy link
Contributor Author

PTAL

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2564 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2564   +/-   ##
=========================================
  Coverage     86.54%   86.54%           
- Complexity     5464     5466    +2     
=========================================
  Files           465      465           
  Lines         21768    21768           
  Branches       2391     2391           
=========================================
  Hits          18839    18839           
- Misses         2086     2087    +1     
+ Partials        843      842    -1
Impacted Files Coverage Δ Complexity Δ
...e/api/codegen/transformer/InitCodeTransformer.java 93.4% <0%> (-1.07%) 99% <0%> (-1%)
...m/google/api/codegen/transformer/SurfaceNamer.java 71.77% <0%> (+0.23%) 204% <0%> (+1%) ⬆️
.../google/api/codegen/config/GapicProductConfig.java 77.27% <0%> (+0.71%) 70% <0%> (+1%) ⬆️
...oogle/api/codegen/util/java/JavaNameFormatter.java 76% <0%> (+4%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2c4a9...ed5d2e7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2564 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2564   +/-   ##
=========================================
  Coverage     86.54%   86.54%           
- Complexity     5464     5466    +2     
=========================================
  Files           465      465           
  Lines         21768    21768           
  Branches       2391     2391           
=========================================
  Hits          18839    18839           
- Misses         2086     2087    +1     
+ Partials        843      842    -1
Impacted Files Coverage Δ Complexity Δ
...e/api/codegen/transformer/InitCodeTransformer.java 93.4% <0%> (-1.07%) 99% <0%> (-1%)
...m/google/api/codegen/transformer/SurfaceNamer.java 71.77% <0%> (+0.23%) 204% <0%> (+1%) ⬆️
.../google/api/codegen/config/GapicProductConfig.java 77.27% <0%> (+0.71%) 70% <0%> (+1%) ⬆️
...oogle/api/codegen/util/java/JavaNameFormatter.java 76% <0%> (+4%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2c4a9...ed5d2e7. Read the comment docs.

@andreamlin andreamlin merged commit 3a2bbcb into googleapis:master Feb 13, 2019
@andreamlin andreamlin deleted the test_enable_string_format branch February 13, 2019 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants