feat!: Update google-auth-library to v10
#1702
Merged
+332
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-goog
commented
Feb 19, 2025
gax/package.json
Outdated
| "node-fetch": "^2.7.0", | ||
| "object-hash": "^3.0.0", | ||
| "proto3-json-serializer": "^2.0.2", | ||
| "protobufjs": "^7.3.2", |
There was a problem hiding this comment.
This was an auto-repair from npm
d-goog
commented
Feb 19, 2025
| | GrpcClientOptions | ||
| | { | ||
| /** | ||
| * @deprecated - use `authClient` for `AuthClient`s instead |
There was a problem hiding this comment.
GrpcClientOptions currently includes this parameter, and with the correct name; authClient.
There was a problem hiding this comment.
We should create a follow-up to clean this up in the next major to avoid confusion
sofisl
approved these changes
Feb 21, 2025
|
Status update: fixing the webpack config |
product-auto-label
bot
added
size: l
|
Status update: figuring out a config issue with webpack 5… |
d-goog
commented
Feb 27, 2025
| @@ -53,7 +82,7 @@ module.exports = { | |||
| use: 'null-loader', | |||
| }, | |||
| { | |||
| test: /node_modules[\\/]google-auth-library/, | |||
| test: /node_modules[\\/]gcp-metadata/, | |||
There was a problem hiding this comment.
Ignoring gcp-metadata in this context, as it is unused, while keeping auth
d-goog
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sofisl
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating
google-auth-libraryto v10 along with improving type-compatibility.Impact
All of the features in
google-auth-libraryv10 and more openAuthClientandGoogleAuthtypes.Testing
Updated and streamlined tests.
Additional Information
This functionality can be improved with this feature (to remove
GoogleAuth<AuthClient>references):GoogleAuth<T>toAuthClientgoogle-auth-library-nodejs#1677🦕