feat!: Normalize GoogleAuth<T>
to AuthClient
#1677
Labels
Breaking Change
next major: breaking change
this is a change that we should wait to bundle into the next major version
priority: p3
Desirable enhancement or fix. May not be included in next release.
semver: major
Hint for users that this is an API breaking change.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
We should normalize
GoogleAuth<T extends AuthClient = JSONClient>
toGoogleAuth<T extends AuthClient = AuthClient>
(andGoogleAuthOptions
as well).Additionally, we should:
change
clientOptions
from:google-auth-library-nodejs/src/auth/googleauth.ts
Lines 106 to 114 in 4f94ffe
to:
In both
GoogleAuth
andGoogleAuthOptions
to accurately match the expected client options.change
cachedCredential
from:google-auth-library-nodejs/src/auth/googleauth.ts
Lines 160 to 161 in f950465
to:
in order to normalize the expected
AuthClient
Dependencies:
AuthClient
Options #1663additionalOptions
from AuthClients #1672Implementation Notes:
ConstructorParameters
results:AuthClient
to the desired overload signature as the first overload ('desired' = whichever one exposes the extendedAuthClientOptions
as the first option).The text was updated successfully, but these errors were encountered: