Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Remove additionalOptions from AuthClients #1672

Open
danielbankhead opened this issue Oct 12, 2023 · 2 comments · May be fixed by #1689
Open

refactor!: Remove additionalOptions from AuthClients #1672

danielbankhead opened this issue Oct 12, 2023 · 2 comments · May be fixed by #1689
Assignees
@Dhoni77
Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

danielbankhead commented Oct 12, 2023 •
edited
Loading

Remove additionalOptions from clients and quotaProjectId param from DownScopedClient, as all options extend from AuthClientOptions as of:
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. semver: major Hint for users that this is an API breaking change. priority: p3 Desirable enhancement or fix. May not be included in next release. next major: breaking change this is a change that we should wait to bundle into the next major version good first issue This issue is a good place to started contributing to this repository. labels Oct 12, 2023
@danielbankhead danielbankhead changed the title feat!: Remove additionalOptions from AuthClients refactor!: Remove additionalOptions from AuthClients Oct 12, 2023
@danielbankhead danielbankhead mentioned this issue Oct 13, 2023
Open
@aeitzman aeitzman mentioned this issue Oct 19, 2023
Merged
@Dhoni77
Copy link

Dhoni77 commented Nov 7, 2023

Hi @danielbankhead I would like to work on this

@Dhoni77 Dhoni77 linked a pull request Nov 7, 2023 that will close this issue
Open
@danielbankhead
Copy link
Contributor Author

@Dhoni77 Done! Take your time as this refactor is a breaking change and we won’t release another major for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhoni77 Dhoni77

Labels
Breaking Change good first issue This issue is a good place to started contributing to this repository. next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. semver: major Hint for users that this is an API breaking change. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove additionalOptions from AuthClients Dhoni77/google-auth-library-nodejs
2 participants
@danielbankhead @Dhoni77