Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove additionalOptions from AuthClients #1689

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor!: remove additionalOptions from AuthClients #1689

wants to merge 3 commits into from

Conversation

Dhoni77
Copy link

@Dhoni77 Dhoni77 commented Nov 7, 2023

Fixes #1672 🦕

  • Remove additionalOptions from clients and quotaProjectId param from DownScopedClient

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 7, 2023
@danielbankhead danielbankhead changed the title refactor: remove additionalOptions from AuthClients refactor!: remove additionalOptions from AuthClients Nov 7, 2023
@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2023
danielbankhead
danielbankhead approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Dhoni77 Dhoni77 marked this pull request as ready for review November 9, 2023 10:17
@Dhoni77 Dhoni77 requested review from a team as code owners November 9, 2023 10:17
@Dhoni77 Dhoni77 changed the title refactor!: remove additionalOptions from AuthClients refactor: remove additionalOptions from AuthClients Nov 9, 2023
@danielbankhead danielbankhead changed the title refactor: remove additionalOptions from AuthClients refactor!: remove additionalOptions from AuthClients Nov 10, 2023
@danielbankhead danielbankhead added the next major: breaking change this is a change that we should wait to bundle into the next major version label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor!: Remove additionalOptions from AuthClients
2 participants
@Dhoni77 @danielbankhead