Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the link to ADC documentation #2379

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

amanda-tarafa
Copy link
Contributor

This link is included in the exception message if ADC is requested and is not setup.

This change has been requested by the Auth TW team.

This link is included in the exception message if ADC is requested and is not setup.
@amanda-tarafa amanda-tarafa requested a review from jskeet March 31, 2023 15:52
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner March 31, 2023 15:52
@jskeet
Copy link
Collaborator

jskeet commented Mar 31, 2023

Currently the new link just redirects to the old one... is that expected?

@amanda-tarafa
Copy link
Contributor Author

Currently the new link just redirects to the old one... is that expected?

Yes I noticed that as well, I'll confirm internally, I suppose they might be in the midst of changes and the new link will be the preferred one going forward. I'll merge but we won't release this just yet.

@amanda-tarafa amanda-tarafa merged commit d848e8a into main Mar 31, 2023
@amanda-tarafa amanda-tarafa deleted the amanda-tarafa-patch-1 branch March 31, 2023 20:47
amanda-tarafa added a commit to amanda-tarafa/google-api-dotnet-client that referenced this pull request Jun 14, 2023
Features

- googleapis#2429 Utilities for date/time parsing.
- googleapis#2394 Which improves impersonation support.
- googleapis#2349 and googleapis#2379 Which improve error reported when ADC is not configured.
amanda-tarafa added a commit that referenced this pull request Jun 14, 2023
Features

- #2429 Utilities for date/time parsing.
- #2394 Which improves impersonation support.
- #2349 and #2379 Which improve error reported when ADC is not configured.
amanda-tarafa added a commit to amanda-tarafa/google-api-dotnet-client that referenced this pull request Jun 26, 2023
Updates support version: 1.61.0 - beta02 -> 1.61.0

Features

- Improvements for  date/time parsing.
  - googleapis#2441
  - googleapis#2432
  - googleapis#2429
- googleapis#2435 PKCE support.
- googleapis#2394 Which improves impersonation support.
- googleapis#2349 and googleapis#2379 Which improve error reported when ADC is not configured.
amanda-tarafa added a commit that referenced this pull request Jun 26, 2023
Updates support version: 1.61.0 - beta02 -> 1.61.0

Features

- Improvements for  date/time parsing.
  - #2441
  - #2432
  - #2429
- #2435 PKCE support.
- #2394 Which improves impersonation support.
- #2349 and #2379 Which improve error reported when ADC is not configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants