feat: Utility methods to support google-datetime format (and eventually others) #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: only the first commit will be merged. The second is for demonstration purposes. |
amanda-tarafa
approved these changes
Jun 16, 2023
| private string _timestampRaw; | ||
|
|
||
| private object _timestamp; | ||
|
|
||
| /// <summary>The timestamp when this issue appeared.</summary> | ||
| [Newtonsoft.Json.JsonPropertyAttribute("timestamp")] |
There was a problem hiding this comment.
If we were to move this one to TimestampDateTimeOffset (by specifying to use GetDateTimeOffsetFromString to serialize it) would that give us the failure right before performing the request instead of having to wait for the server to do that?
There was a problem hiding this comment.
I think so - but we'd have to also add a converter (either specified in the property or in general) to make sure that the DateTimeOffset is serialized correctly. It would work, but there'd be more risk of problems elsewhere IMO.
jskeet
force-pushed
the
google-format-utilities
branch
from
4057010 to
0025082
Compare
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 16, 2023
Features - googleapis#2432 More utilities for date/time parsing.
amanda-tarafa
added a commit
that referenced
this pull request
Jun 16, 2023
Features - #2432 More utilities for date/time parsing.
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 26, 2023
Updates support version: 1.61.0 - beta02 -> 1.61.0 Features - Improvements for date/time parsing. - googleapis#2441 - googleapis#2432 - googleapis#2429 - googleapis#2435 PKCE support. - googleapis#2394 Which improves impersonation support. - googleapis#2349 and googleapis#2379 Which improve error reported when ADC is not configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movement towards #2040, but doesn't finish fixing it yet.