Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: moved quickstart/ -> google/cloud/spanner/ #1479

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Apr 30, 2020

Fixes: googleapis/google-cloud-cpp#3973


This change is Reviewable

@devjgm devjgm requested a review from coryan April 30, 2020 21:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2020
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Using a draft PR and asking for a review at the same time is a mixed message.

Reviewed 23 of 23 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devbww, @mr-salty, and @scotthart)

@devjgm devjgm marked this pull request as ready for review April 30, 2020 21:46
@devjgm
Copy link
Contributor Author

devjgm commented Apr 30, 2020

Using a draft PR and asking for a review at the same time is a mixed message.

I thought it only notified reviewers after I clicked the "ready for review" button. I assumed that I was just filling in the reviewers field, and they'd be notified once it was ready.... the github UI for draft PRs is itself a mixed message.

But sorry about that. TIL.

@coryan
Copy link
Contributor

coryan commented Apr 30, 2020

Using a draft PR and asking for a review at the same time is a mixed message.

I thought it only notified reviewers after I clicked the "ready for review" button. I assumed that I was just filling in the reviewers field, and they'd be notified once it was ready....

Hmm... Maybe. I am subscribed to get everything in googleapis/google-cloud-cpp*, so I might be notified too early.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1479 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
- Coverage   95.61%   95.60%   -0.02%     
==========================================
  Files         194      192       -2     
  Lines       15919    15934      +15     
==========================================
+ Hits        15221    15233      +12     
- Misses        698      701       +3     
Impacted Files Coverage Δ
google/cloud/spanner/internal/log_wrapper.h 75.00% <0.00%> (-9.62%) ⬇️
google/cloud/spanner/internal/polling_loop.h 83.33% <0.00%> (-9.53%) ⬇️
...loud/spanner/internal/partial_result_set_resume.cc 90.90% <0.00%> (-4.55%) ⬇️
...loud/spanner/internal/partial_result_set_source.cc 93.24% <0.00%> (-1.36%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.48% <0.00%> (-0.93%) ⬇️
google/cloud/spanner/keys.h 100.00% <0.00%> (ø)
google/cloud/spanner/internal/session.h 100.00% <0.00%> (ø)
google/cloud/spanner/session_pool_options.h 100.00% <0.00%> (ø)
google/cloud/spanner/internal/transaction_impl.h 100.00% <0.00%> (ø)
...oogle/cloud/spanner/internal/instance_admin_stub.h
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8063b...8ff5039. Read the comment docs.

@devjgm devjgm merged commit 8976440 into googleapis:master Apr 30, 2020
@devjgm devjgm deleted the move-quickstart branch April 30, 2020 23:16
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…loud-cpp-spanner#1479)

* feat: moved quickstart/ -> google/cloud/spanner/

Fixes: googleapis#3973

* fixed quickstart path in build script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move spanner's quickstart/ -> google/cloud/spanner/quickstart/
3 participants