Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move spanner's quickstart/ -> google/cloud/spanner/quickstart/ #3973

Closed
devjgm opened this issue Apr 30, 2020 · 0 comments · Fixed by googleapis/google-cloud-cpp-spanner#1479
Closed

Move spanner's quickstart/ -> google/cloud/spanner/quickstart/ #3973

devjgm opened this issue Apr 30, 2020 · 0 comments · Fixed by googleapis/google-cloud-cpp-spanner#1479
Assignees
@devjgm
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Milestone
Monorepo: Move go...

Comments

@devjgm
Copy link
Contributor

devjgm commented Apr 30, 2020

In the new monorepo, each product's quickstart/ lives in its own product directory. We should move Spanner's now, before merging spanner into the monorepo.
@devjgm devjgm added the type: cleanup An internal cleanup or hygiene concern. label Apr 30, 2020
@devjgm devjgm added the api: spanner Issues related to the Spanner API. label Apr 30, 2020
devjgm added a commit to devjgm/google-cloud-cpp-spanner that referenced this issue Apr 30, 2020
@devjgm
feat: moved quickstart/ -> google/cloud/spanner/
7b0ece9 
Fixes: googleapis/google-cloud-cpp#3973
devjgm added a commit to devjgm/google-cloud-cpp-spanner that referenced this issue Apr 30, 2020
@devjgm
feat: moved quickstart/ -> google/cloud/spanner/
dc472e0 
Fixes: googleapis/google-cloud-cpp#3973
@devjgm devjgm mentioned this issue Apr 30, 2020
Merged
devjgm added a commit to googleapis/google-cloud-cpp-spanner that referenced this issue Apr 30, 2020
@devjgm
feat: moved quickstart/ -> google/cloud/spanner/ (#1479)
8976440 
* feat: moved quickstart/ -> google/cloud/spanner/

Fixes: googleapis/google-cloud-cpp#3973

* fixed quickstart path in build script
devjgm added a commit to devjgm/google-cloud-cpp that referenced this issue May 7, 2020
@devjgm
feat: moved quickstart/ -> google/cloud/spanner/ (googleapis/google-c…
dc3c4f2 
…loud-cpp-spanner#1479)

* feat: moved quickstart/ -> google/cloud/spanner/

Fixes: googleapis#3973

* fixed quickstart path in build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devjgm devjgm

Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
Monorepo: Move google-cloud-cpp-spanner
Development

Successfully merging a pull request may close this issue.

feat: moved quickstart/ -> google/cloud/spanner/ devjgm/google-cloud-cpp-spanner
1 participant
@devjgm