Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update main with v1.30.1 changes #7160

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Aug 11, 2021

This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner August 11, 2021 20:31
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 44dfc9ee28818e746c6415529b2b8cef1966f37f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #7160 (7c09f9e) into main (1c3fedd) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7160      +/-   ##
==========================================
- Coverage   94.44%   94.43%   -0.01%     
==========================================
  Files        1310     1310              
  Lines      113293   113293              
==========================================
- Hits       106998   106992       -6     
- Misses       6295     6301       +6     
Impacted Files Coverage Δ
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
...le/cloud/spanner/database_admin_connection_test.cc 99.20% <0.00%> (-0.50%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.59% <0.00%> (+0.37%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.60% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3fedd...7c09f9e. Read the comment docs.

CHANGELOG.md Outdated
@@ -64,6 +64,18 @@
removed. If your code previously relied on `sor.status() = new_status` you
should change it to `sor = new_status`. ([#7150](https://github.com/googleapis/google-cloud-cpp/pull/7150))


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it looks like we only have single-blank-line separators between all the other releases.

Copy link
Member Author

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @devbww)


CHANGELOG.md, line 67 at r1 (raw file):

Previously, devbww (Bradley White) wrote…

FWIW, it looks like we only have single-blank-line separators between all the other releases.

blank line removed

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c3bea23fd3aa314a9ad73bdd5b54e41d6604acdd

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7c09f9ed8cd3f4baa7d1956f4b4f9e5b10669847

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@scotthart scotthart merged commit f9d58d6 into googleapis:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants