fix(storage): use CA info options in credentials #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally dropped the `options_` parameter when moving the request construction from the constructor to when the request is issued. This restores the use of the `options_` parameter and adds unit tests to prevent such breaks in the future.
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
devjgm
approved these changes
Sep 2, 2021
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7263 +/- ##
==========================================
- Coverage 94.36% 94.35% -0.01%
==========================================
Files 1317 1317
Lines 114503 114564 +61
==========================================
+ Hits 108051 108098 +47
- Misses 6452 6466 +14
Continue to review full report at Codecov.
|
|
The GCS+gRPC failure is a known bug in the service. And GCS+gRPC is not GA. I am going to ignore it. |
dbolduc
pushed a commit
to dbolduc/google-cloud-cpp
that referenced
this pull request
Sep 4, 2021
I accidentally dropped the `options_` parameter when moving the request construction from the constructor to when the request is issued. This restores the use of the `options_` parameter and adds unit tests to prevent such breaks in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally dropped the
options_parameter when moving the requestconstruction from the constructor to when the request is issued. This
restores the use of the
options_parameter and adds unit tests toprevent such breaks in the future.
Fixes #7160
This change is