feat(bigquery): enable project autodetection, expose project ids further #4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR supersedes: googleapis#4076 Related: googleapis#1294 With this change, project autodetection is enabled via use of a sentinel value, and the retained project identifier is now exposed on the Client and Job resources via the Project() function.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
crwilcox
approved these changes
Jun 24, 2021
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
shollyman
added a commit
to shollyman/google-cloud-go
that referenced
this pull request
Jun 25, 2021
This adds a minor correction to Job's access to the underlying project. While the access on the Client is more accurately called `Project()` as it accepts project ID or project number, in this case the field is part of the underlying JobReference type. This was added yesterday in googleapis#4312 and hasn't made it into a release cut yet, so addressing this now before release.
codyoss
pushed a commit
that referenced
this pull request
Jun 29, 2021
…4320) This adds a minor correction to Job's access to the underlying project. While the access on the Client is more accurately called `Project()` as it accepts project ID or project number, in this case the field is part of the underlying JobReference type. This was added yesterday in #4312 and hasn't made it into a release cut yet, so addressing this now before release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR supersedes: #4076
Related: #1294
With this change, project autodetection is enabled via use of a sentinel
value, and the retained project identifier is now exposed on the Client
and Job resources via the Project() function.