Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): minor rename to feature that's not yet in a release #4320

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 25, 2021

This adds a minor correction to Job's access to the underlying project.
While the access on the Client is more accurately called Project() as
it accepts project ID or project number, in this case the field is part
of the underlying JobReference type.

This was added yesterday in
#4312 and hasn't made
it into a release cut yet, so addressing this now before release.

This adds a minor correction to Job's access to the underlying project.
While the access on the Client is more accurately called `Project()` as
it accepts project ID or project number, in this case the field is part
of the underlying JobReference type.

This was added yesterday in
googleapis#4312 and hasn't made
it into a release cut yet, so addressing this now before release.
@shollyman shollyman requested a review from a team as a code owner June 25, 2021 16:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jun 25, 2021
@shollyman shollyman changed the title fix(bigquery): minor rename to feature that's not yet in a release. fix(bigquery): minor rename to feature that's not yet in a release Jun 25, 2021
@shollyman shollyman requested a review from tbpg June 25, 2021 16:25
@shollyman
Copy link
Contributor Author

Broken kokoro is the apidiff warning about the change.

@shollyman shollyman requested a review from codyoss June 29, 2021 17:08
@codyoss
Copy link
Member

codyoss commented Jun 29, 2021

LGTM since this was not yet released.

@codyoss codyoss merged commit ef8d138 into googleapis:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants