fix(storage): respect STORAGE_EMULATOR_HOST in signedURL #5411
Conversation
ChrisBr
force-pushed
the
cbruckmayer/storage-emulator
branch
from
e9ba020
to
0bec397
Compare
codyoss
changed the title
product-auto-label
bot
added
the
api: storage
| return os.Getenv("STORAGE_EMULATOR_HOST") | ||
| } else { | ||
| return "storage.googleapis.com" | ||
| } | ||
| } | ||
|
|
||
| func (s virtualHostedStyle) host(bucket string) string { |
There was a problem hiding this comment.
The path for virtual hosted should be updated as well probably?
| @@ -308,7 +308,11 @@ type bucketBoundHostname struct { | |||
| } | |||
|
|
|||
| func (s pathStyle) host(bucket string) string { | |||
| return "storage.googleapis.com" | |||
| if os.Getenv("STORAGE_EMULATOR_HOST") { | |||
| return os.Getenv("STORAGE_EMULATOR_HOST") | |||
There was a problem hiding this comment.
We accept STORAGE_EMULATOR_HOST both with and without a scheme, so we should strip the scheme if it is present. See https://github.com/googleapis/google-cloud-go/blob/main/storage/storage.go#L154
|
Hi @ChrisBr, thanks for your contribution! I made a PR to your branch to incorporate the changes suggested by @tritone. Can you look that over and sign the CLA as well? To sign the CLA, please visit https://cla.developers.google.com/. Once you've signed, click here https://cla.developers.google.com/github/rescan?pr=googleapis%2Fgoogle-cloud-go%2Fpull%2F5411&key=%01~%D4%13%80JC%15G%B8Y%92%FC%87%D9%82%D4%CE%97%DC%40&expiry=2022-03-15 to update the check |
|
Sorry for the delay, will check tomorrow with the CLA 👍 |
|
The CLA is still under review with my employer Shopify but I will hopefully have an answer in the next couple of days. Sorry for the delay. |
|
@BrennaEpp signed the CLA 👍 Thanks for your patience. |
product-auto-label
bot
added
the
stale: old
|
These changes were merged in #5673. Thank you for your contribution! |
Respect STORAGE_EMULATOR_HOST in signedURL.