Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): respect STORAGE_EMULATOR_HOST in signedURL #5673

Merged
merged 10 commits into from
Mar 11, 2022
Merged

fix(storage): respect STORAGE_EMULATOR_HOST in signedURL #5673

merged 10 commits into from
Mar 11, 2022

Conversation

BrennaEpp
Copy link
Contributor

No description provided.

@BrennaEpp BrennaEpp requested review from a team as code owners February 18, 2022 19:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Feb 18, 2022
tritone
tritone reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments, overall LGTM

storage/storage.go Show resolved Hide resolved
storage/storage.go Outdated Show resolved Hide resolved
@BrennaEpp BrennaEpp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@BrennaEpp BrennaEpp enabled auto-merge (squash) March 3, 2022 23:36
@BrennaEpp BrennaEpp requested review from a team as code owners March 10, 2022 23:40
@BrennaEpp BrennaEpp requested a review from a team March 10, 2022 23:40
@BrennaEpp BrennaEpp requested review from dmahugh, telpirion and a team as code owners March 10, 2022 23:40
@product-auto-label product-auto-label bot added size: xxl Pull request size is extra extra large. and removed size: s Pull request size is small. labels Mar 10, 2022
@snippet-bot
Copy link

snippet-bot bot commented Mar 10, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xxl Pull request size is extra extra large. labels Mar 10, 2022
@BrennaEpp BrennaEpp merged commit 1c249ae into googleapis:main Mar 11, 2022
@release-please release-please bot mentioned this pull request Mar 11, 2022
Merged
@aalexand aalexand removed the request for review from a team March 11, 2022 00:23
@BrennaEpp BrennaEpp mentioned this pull request Mar 14, 2022
Closed
@BrennaEpp BrennaEpp deleted the storage-emulator branch February 8, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@dmahugh dmahugh Awaiting requested review from dmahugh

@telpirion telpirion Awaiting requested review from telpirion

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrennaEpp @tritone @kokoro-team @ChrisBr