Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we repackage the spi layer? #422

Closed
ajkannan opened this issue Nov 26, 2015 · 4 comments · Fixed by #742
Closed

Should we repackage the spi layer? #422

ajkannan opened this issue Nov 26, 2015 · 4 comments · Fixed by #742
Assignees
@ajkannan
Labels
type: question Request for information or clarification. Not an issue.

Comments

@ajkannan
Copy link

Right now all services' spi layers are bundled into one package (com.google.gcloud.spi). While this provides the convenience of separating the spi javadoc from the api javadoc, the one package may not make sense as we add more and more services.
@ajkannan ajkannan added type: question Request for information or clarification. Not an issue. packaging labels Nov 26, 2015
@mziccard
Copy link
Contributor

@ajkannan Could you please add more details on this? Are you suggesting to add one spi package per-service?

@ajkannan
Copy link
Author

Yes; we could make one spi package per service, and make sure that they get packaged separately from the api layer services

@aozarov aozarov mentioned this issue Mar 10, 2016
Merged
@mziccard mziccard mentioned this issue Mar 10, 2016
Merged
@mziccard mziccard added the api: compute Issues related to the Compute Engine API. label Apr 3, 2016
@mziccard
Copy link
Contributor

mziccard commented Apr 3, 2016

Reopening this. Should be closed as soon as this is also applied to compute.

@ajkannan ajkannan reopened this Apr 8, 2016
@mziccard mziccard mentioned this issue Apr 12, 2016
Merged
@mziccard mziccard removed the api: compute Issues related to the Compute Engine API. label Apr 13, 2016
@mziccard
Copy link
Contributor

Closed with #742 and #901

github-actions bot pushed a commit that referenced this issue Jun 21, 2022
@gcf-owl-bot
chore: Integrate new gapic-generator-java and rules_gapic (#422)
44fd0bb 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 454027580

Source-Link: googleapis/googleapis@1b22277

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@chingor13
build: add owlbot config (googleapis#422)
144b956
github-actions bot pushed a commit that referenced this issue Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#422)
0f716a0 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajkannan ajkannan

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create service-specific spi packages mziccard/gcloud-java
2 participants
@mziccard @ajkannan