Create service-specific spi packages #742

mziccard · 2016-03-10T20:44:25Z

This fixes #422. We should probably open a new issue for modules that are currently being developed (dns and compute).

...cemanager/src/main/java/com/google/gcloud/resourcemanager/spi/DefaultResourceManagerRpc.java


-import static com.google.gcloud.spi.ResourceManagerRpc.Option.FIELDS;


ajkannan · 2016-03-10T21:02:33Z

Since we now add the package name before the "spi", the linter complains about import order. I'll paste the relevant ones + line numbers below once I curate the list.

ajkannan · 2016-03-10T21:04:57Z

gcloud-java-storage/src/test/java/com/google/gcloud/storage/SerializationTest.java:30: warning: Wrong order for com.google.gcloud.storage.Acl.Project.ProjectRole import.
gcloud-java-storage/src/test/java/com/google/gcloud/storage/StorageImplTest.java:43: warning: Wrong order for com.google.gcloud.storage.Storage.CopyRequest import.
gcloud-java-storage/src/main/java/com/google/gcloud/storage/Blob.java:29: warning: Wrong order for com.google.gcloud.storage.Storage.BlobTargetOption import.
gcloud-java-storage/src/main/java/com/google/gcloud/storage/Bucket.java:30: warning: Wrong order for com.google.gcloud.storage.Storage.BlobGetOption import.
gcloud-java-examples/src/main/java/com/google/gcloud/examples/storage/StorageExample.java:24: warning: Wrong order for com.google.gcloud.storage.Blob import.
gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java:42: warning: Wrong order for com.google.gcloud.datastore.spi.DatastoreRpc import.
gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreOptionsTest.java:26: warning: Wrong order for com.google.gcloud.datastore.spi.DatastoreRpc import.
gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/ResourceManagerImplTest.java:34: warning: Wrong order for com.google.gcloud.resourcemanager.spi.ResourceManagerRpc import.
gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/LocalResourceManagerHelperTest.java:12: warning: Wrong order for com.google.gcloud.resourcemanager.spi.DefaultResourceManagerRpc import.

ajkannan · 2016-03-10T21:12:54Z

A few of nits, otherwise looks good!

mziccard · 2016-03-10T22:24:41Z

Fixed imports!

ajkannan · 2016-03-11T02:43:06Z

LGTM

Create service-specific spi packages

Moved spi package to dns.spi as per #742

Source-Link: googleapis/synthtool@625c20e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:58ccd4737212f64a7dd4b3063d447447acf71a2b9d409eab19fc7a00b18eadc0 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.1 (#742) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks).

🤖 I have created a release *beep* *boop* --- ## [2.5.2](googleapis/java-bigqueryconnection@v2.5.1...v2.5.2) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#742](googleapis/java-bigqueryconnection#742)) ([a41bac5](googleapis/java-bigqueryconnection@a41bac5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…onfig to v1.5.4 (#742)

….2.6 (#742) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam) | `1.2.5` -> `1.2.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.6/compatibility-slim/1.2.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.6/confidence-slim/1.2.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.2.6`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#126-httpsgithubcomgoogleapisjava-iamcomparev125v126-2022-03-01) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.2.5...v1.2.6) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ### [2.5.6](googleapis/java-core@v2.5.5...v2.5.6) (2022-03-01) ### Dependencies * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.6 ([#742](googleapis/java-core#742)) ([a96416b](googleapis/java-core@a96416b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

….8.1 (#742)

Create service-specific spi packages

407c436

mziccard added the packaging label Mar 10, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2016

ajkannan reviewed Mar 10, 2016
View reviewed changes

...cemanager/src/main/java/com/google/gcloud/resourcemanager/spi/DefaultResourceManagerRpc.java

import static com.google.gcloud.spi.ResourceManagerRpc.Option.FIELDS;

This comment was marked as spam.

Sign in to view

Reorder and add imports

fd7d84d

ajkannan added a commit that referenced this pull request Mar 11, 2016

Merge pull request #742 from mziccard/rename-spi

0d38c67

Create service-specific spi packages

ajkannan merged commit 0d38c67 into googleapis:master Mar 11, 2016

mderka added a commit to mderka/gcloud-java that referenced this pull request Mar 14, 2016

Moved spi package to dns.spi as per googleapis#742

96e380c

mderka mentioned this pull request Mar 14, 2016

Moved spi package to dns.spi as per #742 #748

Merged

ajkannan added a commit that referenced this pull request Mar 14, 2016

Merge pull request #748 from mderka/spi-refactor

6be68bc

Moved spi package to dns.spi as per #742

mziccard mentioned this pull request Apr 13, 2016

Should we repackage the spi layer? #422

Closed

github-actions bot pushed a commit that referenced this pull request Nov 9, 2022

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

b7bb476

…onfig to v1.5.4 (#742)

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.auth:google-auth-library-bom to v1…

dabdbdf

….8.1 (#742)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create service-specific spi packages #742

Create service-specific spi packages #742

mziccard commented Mar 10, 2016

This comment was marked as spam.

ajkannan commented Mar 10, 2016

ajkannan commented Mar 10, 2016

ajkannan commented Mar 10, 2016

mziccard commented Mar 10, 2016

ajkannan commented Mar 11, 2016


		import static com.google.gcloud.spi.ResourceManagerRpc.Option.FIELDS;

Create service-specific spi packages #742

Create service-specific spi packages #742

Conversation

mziccard commented Mar 10, 2016

This comment was marked as spam.

ajkannan commented Mar 10, 2016

ajkannan commented Mar 10, 2016

ajkannan commented Mar 10, 2016

mziccard commented Mar 10, 2016

ajkannan commented Mar 11, 2016